Title: [109169] trunk
- Revision
- 109169
- Author
- [email protected]
- Date
- 2012-02-28 16:37:05 -0800 (Tue, 28 Feb 2012)
Log Message
All mouse events after a right click are ignored when they came from WebkitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=77350
Patch by Hugo Parente Lima <[email protected]> on 2012-02-28
Reviewed by Chang Shu.
Source/WebKit2:
Never ignore mouse events when using sync events, even if the context menu is being
show but the Ui did replied the ShowContextMenu event with a ContextMenuHidden.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEventSyncForTesting):
LayoutTests:
Unskip fast/events/mouse-click-events.html.
* platform/qt-5.0-wk2/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (109168 => 109169)
--- trunk/LayoutTests/ChangeLog 2012-02-29 00:27:41 UTC (rev 109168)
+++ trunk/LayoutTests/ChangeLog 2012-02-29 00:37:05 UTC (rev 109169)
@@ -1,3 +1,14 @@
+2012-02-28 Hugo Parente Lima <[email protected]>
+
+ All mouse events after a right click are ignored when they came from WebkitTestRunner
+ https://bugs.webkit.org/show_bug.cgi?id=77350
+
+ Reviewed by Chang Shu.
+
+ Unskip fast/events/mouse-click-events.html.
+
+ * platform/qt-5.0-wk2/Skipped:
+
2012-02-28 Rafael Brandao <[email protected]>
[Qt] Unskip compositing & 3d-rendering tests
Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (109168 => 109169)
--- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-02-29 00:27:41 UTC (rev 109168)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-02-29 00:37:05 UTC (rev 109169)
@@ -54,7 +54,6 @@
fast/events/contextmenu-scrolled-page-with-frame.html
fast/events/continuous-platform-wheelevent-in-scrolling-div.html
fast/events/fire-mousedown-while-pressing-mouse-button.html
-fast/events/mouse-click-events.html
fast/events/mouseup-from-button2.html
fast/events/open-window-from-another-frame.html
fast/events/platform-wheelevent-in-scrolling-div.html
Modified: trunk/Source/WebKit2/ChangeLog (109168 => 109169)
--- trunk/Source/WebKit2/ChangeLog 2012-02-29 00:27:41 UTC (rev 109168)
+++ trunk/Source/WebKit2/ChangeLog 2012-02-29 00:37:05 UTC (rev 109169)
@@ -1,3 +1,16 @@
+2012-02-28 Hugo Parente Lima <[email protected]>
+
+ All mouse events after a right click are ignored when they came from WebkitTestRunner
+ https://bugs.webkit.org/show_bug.cgi?id=77350
+
+ Reviewed by Chang Shu.
+
+ Never ignore mouse events when using sync events, even if the context menu is being
+ show but the Ui did replied the ShowContextMenu event with a ContextMenuHidden.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::mouseEventSyncForTesting):
+
2012-02-28 Alexey Proskuryakov <[email protected]>
More build fix.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (109168 => 109169)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-02-29 00:27:41 UTC (rev 109168)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-02-29 00:37:05 UTC (rev 109169)
@@ -1299,12 +1299,6 @@
void WebPage::mouseEventSyncForTesting(const WebMouseEvent& mouseEvent, bool& handled)
{
- // Don't try to handle any pending mouse events if a context menu is showing.
- if (m_isShowingContextMenu) {
- handled = true;
- return;
- }
-
handled = m_pageOverlay && m_pageOverlay->mouseEvent(mouseEvent);
if (!handled) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
