Title: [109172] trunk/Source/_javascript_Core
- Revision
- 109172
- Author
- [email protected]
- Date
- 2012-02-28 17:13:08 -0800 (Tue, 28 Feb 2012)
Log Message
Some run-_javascript_core-tests broken for 32-bit debug
https://bugs.webkit.org/show_bug.cgi?id=79844
Rubber stamped by Oliver Hunt.
These assertions are just plain wrong for 32-bit. We could either have a massive
assertion that depends on value representation, that has to be changed every
time we change the JITs, resulting in a bug tail of debug-mode crashes, or we
could get rid of the assertions. I pick the latter.
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (109171 => 109172)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-29 01:12:57 UTC (rev 109171)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-29 01:13:08 UTC (rev 109172)
@@ -1,3 +1,19 @@
+2012-02-28 Filip Pizlo <[email protected]>
+
+ Some run-_javascript_core-tests broken for 32-bit debug
+ https://bugs.webkit.org/show_bug.cgi?id=79844
+
+ Rubber stamped by Oliver Hunt.
+
+ These assertions are just plain wrong for 32-bit. We could either have a massive
+ assertion that depends on value representation, that has to be changed every
+ time we change the JITs, resulting in a bug tail of debug-mode crashes, or we
+ could get rid of the assertions. I pick the latter.
+
+ * dfg/DFGOperations.cpp:
+ * jit/JITStubs.cpp:
+ (JSC::DEFINE_STUB_FUNCTION):
+
2012-02-28 Mark Hahnenberg <[email protected]>
Get rid of padding cruft in CopiedBlock
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (109171 => 109172)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-02-29 01:12:57 UTC (rev 109171)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-02-29 01:13:08 UTC (rev 109172)
@@ -740,9 +740,6 @@
JSValue src1 = JSValue::decode(encodedOp1);
JSValue src2 = JSValue::decode(encodedOp2);
- ASSERT((src1.isCell() && src2.isCell())
- || src1.isDouble() || src2.isDouble());
-
return JSValue::strictEqual(exec, src1, src2);
}
Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (109171 => 109172)
--- trunk/Source/_javascript_Core/jit/JITStubs.cpp 2012-02-29 01:12:57 UTC (rev 109171)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp 2012-02-29 01:13:08 UTC (rev 109172)
@@ -3295,9 +3295,6 @@
JSValue src1 = stackFrame.args[0].jsValue();
JSValue src2 = stackFrame.args[1].jsValue();
- ASSERT((src1.isCell() && src2.isCell())
- || src1.isDouble() || src2.isDouble());
-
bool result = JSValue::strictEqual(stackFrame.callFrame, src1, src2);
CHECK_FOR_EXCEPTION_AT_END();
return JSValue::encode(jsBoolean(result));
@@ -3326,9 +3323,6 @@
JSValue src1 = stackFrame.args[0].jsValue();
JSValue src2 = stackFrame.args[1].jsValue();
- ASSERT((src1.isCell() && src2.isCell())
- || src1.isDouble() || src2.isDouble());
-
bool result = !JSValue::strictEqual(stackFrame.callFrame, src1, src2);
CHECK_FOR_EXCEPTION_AT_END();
return JSValue::encode(jsBoolean(result));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
