Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a8619910b2256e29f8a4e63ea3d9542b2561f415
https://github.com/WebKit/WebKit/commit/a8619910b2256e29f8a4e63ea3d9542b2561f415
Author: Richard Robinson <[email protected]>
Date: 2023-05-25 (Thu, 25 May 2023)
Changed paths:
A LayoutTests/fast/images/resources/text-with-rotated-text.png
A
LayoutTests/fast/images/text-recognition/ios/do-not-coalesce-non-adjacent-selection-rects-in-image-overlay-expected.txt
A
LayoutTests/fast/images/text-recognition/ios/do-not-coalesce-non-adjacent-selection-rects-in-image-overlay.html
M Source/WebCore/rendering/RenderObject.cpp
Log Message:
-----------
Text selection doesn't appear correct for partially rotated text
https://bugs.webkit.org/show_bug.cgi?id=257301
rdar://109173149
Reviewed by Wenson Hsieh.
In 263159@main, a mechanism was added to detect if two quads are overlapping.
This mechanism
turned out to return false positives, resulting in some quads being erroneously
coalesced.
Upon further investigation, this mechanism isn't actually needed. Rather,
simply expanding the
threshold for the existing `areCloseEnoughToCoalesce` mechanism is sufficient
to cover this, and
does not give false positives.
* LayoutTests/fast/images/resources/text-with-rotated-text.png: Added.
*
LayoutTests/fast/images/text-recognition/ios/do-not-coalesce-non-adjacent-selection-rects-in-image-overlay-expected.txt:
Added.
*
LayoutTests/fast/images/text-recognition/ios/do-not-coalesce-non-adjacent-selection-rects-in-image-overlay.html:
Added.
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::coalesceSelectionGeometryWithAdjacentQuadsIfPossible):
Canonical link: https://commits.webkit.org/264556@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
