Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3fb10034184d64c5a4bb2b753c1f2dbbf31b4e1f
https://github.com/WebKit/WebKit/commit/3fb10034184d64c5a4bb2b753c1f2dbbf31b4e1f
Author: Youenn Fablet <[email protected]>
Date: 2023-05-31 (Wed, 31 May 2023)
Changed paths:
A LayoutTests/fast/mediastream/getUserMedia-echoCancellation-expected.txt
A LayoutTests/fast/mediastream/getUserMedia-echoCancellation.html
M Source/WebCore/Modules/mediastream/MediaDevices.cpp
M Source/WebCore/platform/mediastream/MediaConstraints.cpp
M Source/WebCore/platform/mediastream/MediaConstraints.h
Log Message:
-----------
Set echoCancellation to true if not explicitly set within a getUserMedia call
https://bugs.webkit.org/show_bug.cgi?id=257495
rdar://110010294
Reviewed by Eric Carlson.
Before the patch, if the web page does not provide a echoCancellation setting,
we would use whatever setting was used by the previous web application using
the microphone.
This might break some applications that want echoCancellation but do not set it
explicitly.
This change aligns with Chrome's behavior.
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::getUserMedia):
* Source/WebCore/platform/mediastream/MediaConstraints.cpp:
(WebCore::MediaConstraints::setDefaultAudioConstraints):
* Source/WebCore/platform/mediastream/MediaConstraints.h:
* LayoutTests/fast/mediastream/getUserMedia-echoCancellation-expected.txt:
Added.
* LayoutTests/fast/mediastream/getUserMedia-echoCancellation.html: Added.
Canonical link: https://commits.webkit.org/264721@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
