Title: [109235] trunk/Tools
- Revision
- 109235
- Author
- [email protected]
- Date
- 2012-02-29 11:48:43 -0800 (Wed, 29 Feb 2012)
Log Message
perftestsrunner can call printer.write() after printer.cleanup()
https://bugs.webkit.org/show_bug.cgi?id=79872
Reviewed by Ryosuke Niwa.
This patch fixes a unittest that was incorrectly calling
PerfTestsRunner.run() twice (which led to a weird state in the
printer object).
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_run_with_upload_json):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (109234 => 109235)
--- trunk/Tools/ChangeLog 2012-02-29 19:40:24 UTC (rev 109234)
+++ trunk/Tools/ChangeLog 2012-02-29 19:48:43 UTC (rev 109235)
@@ -1,3 +1,17 @@
+2012-02-29 Dirk Pranke <[email protected]>
+
+ perftestsrunner can call printer.write() after printer.cleanup()
+ https://bugs.webkit.org/show_bug.cgi?id=79872
+
+ Reviewed by Ryosuke Niwa.
+
+ This patch fixes a unittest that was incorrectly calling
+ PerfTestsRunner.run() twice (which led to a weird state in the
+ printer object).
+
+ * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
+ (MainTest.test_run_with_upload_json):
+
2012-02-29 Balazs Kelemen <[email protected]>
[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (109234 => 109235)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2012-02-29 19:40:24 UTC (rev 109234)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2012-02-29 19:48:43 UTC (rev 109235)
@@ -280,6 +280,10 @@
self.assertEqual(generated_json['builder-name'], 'builder1')
self.assertEqual(generated_json['build-number'], 123)
upload_json_returns_true = False
+
+ runner = self.create_runner(args=['--output-json-path=/mock-checkout/output.json',
+ '--test-results-server', 'some.host', '--platform', 'platform1', '--builder-name', 'builder1', '--build-number', '123'])
+ runner._upload_json = mock_upload_json
self.assertEqual(runner.run(), -3)
def test_upload_json(self):
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
