[webkit-changes] [WebKit/WebKit] df850b: with float:left disappears when editing...</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=webkit-changes@lists.webkit.org&q=from:%22Alan+Baradlay%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">Alan Baradlay</span></span></a></span> <span class="date"><a href="/search?l=webkit-changes@lists.webkit.org&q=date:20230607" rel="nofollow">Wed, 07 Jun 2023 09:52:55 -0700</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre> Branch: refs/heads/main Home: <a rel="nofollow" href="https://github.com/WebKit/WebKit">https://github.com/WebKit/WebKit</a> Commit: df850bbc342ee6caba4371b51ccfde480ab6db54 <a rel="nofollow" href="https://github.com/WebKit/WebKit/commit/df850bbc342ee6caba4371b51ccfde480ab6db54">https://github.com/WebKit/WebKit/commit/df850bbc342ee6caba4371b51ccfde480ab6db54</a> Author: Alan Baradlay <za...@apple.com> Date: 2023-06-07 (Wed, 07 Jun 2023)</pre><pre> Changed paths: M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBox.h M Source/WebCore/rendering/RenderLayer.cpp Log Message: ----------- <textarea> with float:left disappears when editing text <a rel="nofollow" href="https://bugs.webkit.org/show_bug.cgi?id=132188">https://bugs.webkit.org/show_bug.cgi?id=132188</a> <rdar://problem/110093535> Reviewed by Simon Fraser. Consider the following example: <div id=top> <div id=middle> <div id=float_box style="width: 100px; height: 100px;"></div> </div> </div> 1. A float box can intrude into multiple containers ("top" and "middle"). 2. Containers construct FloatingObjects for intruding floats (multiple FloatingObjects can point to the same float when it crosses containers). 3. Float boxes (usually) are painted by the top most container where they intrude ("top"). 4. However self-painting float boxes always paint themselves (this is not specific to floats, all renderers behave like this). 5. FloatingObject's m_paintsFloat controls which container is responsible for painting the (non-self-painting) float box. When a float box goes from self-painting to non-self painting, we need to ensure that one of its containers takes care of painting it by adjusting the associated FloatingObject's paint flag. It is usually done as part of the layout process at RenderBlockFlow::addIntrudingFloats when containers finish running layout on their child renderers (including float boxes) (i.e. the containing block chain takes care of updating this bit). However when the float box is the root of the layout (i.e. subtree layout) none of its containers get the chance to update this paint flag since layout flow never reaches said ancestors. (note when the layout's entry point is the float box, it's guaranteed that none of the intruding/overhanging properties change at the containing block level (i.e. no need to extend the layout to the ancestor chain). At this point this is really only about ensuring that one of the ancestors (through the already constructed FloatingObjects) starts painting this float box. * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::updateFloatBoxAfterSelfPaintingLayerChange): * Source/WebCore/rendering/RenderBox.h: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const): Canonical link: <a rel="nofollow" href="https://commits.webkit.org/264943@main">https://commits.webkit.org/264943@main</a> _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org <a rel="nofollow" href="https://lists.webkit.org/mailman/listinfo/webkit-changes">https://lists.webkit.org/mailman/listinfo/webkit-changes</a> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg200277.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="index.html#200278">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#200278">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg200279.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[webkit-changes] [WebKit/WebKit] df850b: <textarea> with float:left disappears when editing..."> <input type="hidden" name="msgid" value="WebKit/WebKit/push/refs/heads/main/7584d3-df850b@github.com"> <input type="hidden" name="relpath" value="webkit-changes@lists.webkit.org/msg200278.html"> <input type="submit" value=" Alan Baradlay "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="webkit-changes@lists.webkit.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search webkit-changes"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/webkit-changes@lists.webkit.org/">webkit-changes - all messages</a></li> <li class="icons-about"><a href="/webkit-changes@lists.webkit.org/info.html">webkit-changes - about the list</a></li> <li class="icons-expand"><a href="/search?l=webkit-changes@lists.webkit.org&q=subject:%22%5C%5Bwebkit%5C-changes%5C%5D+%5C%5BWebKit%5C%2FWebKit%5C%5D+df850b%5C%3A+%3Ctextarea%3E+with+float%5C%3Aleft+disappears+when+editing...%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg200277.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg200279.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">WebKit/WebKit/push/refs/heads/main/7584d3-df850b@github.com</li> </ul> </div> </body> </html>