Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 82228ed935598ec6fc263134947f46b4d46849f1
https://github.com/WebKit/WebKit/commit/82228ed935598ec6fc263134947f46b4d46849f1
Author: Darin Adler <[email protected]>
Date: 2023-06-10 (Sat, 10 Jun 2023)
Changed paths:
M LayoutTests/fast/css/background-position-serialize-expected.txt
M LayoutTests/fast/css/background-position-serialize.html
M LayoutTests/fast/masking/parsing-webkit-mask-expected.txt
M LayoutTests/fast/masking/parsing-webkit-mask.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-valid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-valid.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-valid.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-valid.sub.html
M Source/WebCore/css/ShorthandSerializer.cpp
Log Message:
-----------
REGRESSION (Safari 16.4, 258767@main): Carcassonne game on boardgamearena.com
unplayable (serialization bug affecting background-position)
https://bugs.webkit.org/show_bug.cgi?id=256814
rdar://109380755
Reviewed by Tim Nguyen.
The code to serialize background-position and mask-position did not correctly
handle the case
where the Y value was 0%. Rearranged the code slightly to resolve this.
* LayoutTests/fast/css/background-position-serialize-expected.txt: Added test
cases.
* LayoutTests/fast/css/background-position-serialize.html: Ditto.
* LayoutTests/fast/masking/parsing-webkit-mask-expected.txt: Ditto.
* LayoutTests/fast/masking/parsing-webkit-mask.html: Ditto.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-valid-expected.txt:
Ditto.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-position-valid.html:
Ditto.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-valid.html:
Updated expectations since initial value of background-position is "0% 0%", not
"0% center".
*
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid-expected.txt:
Added test cases.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid.html:
Ditto.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-valid.sub.html:
Updated expectations since initial value of mask-position is "0% 0%", not "0%
center".
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::serializeLayered const): Rearrange the code to
correctly serialize
background-position-y and mask-position-y as part of a shorthand.
Canonical link: https://commits.webkit.org/265056@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
