Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 809270197668234dc0c8eb099e11723eafa9c247
https://github.com/WebKit/WebKit/commit/809270197668234dc0c8eb099e11723eafa9c247
Author: David Kilzer <[email protected]>
Date: 2023-06-15 (Thu, 15 Jun 2023)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
Log Message:
-----------
Fix use-after-move of playerView in
VideoFullscreenManagerProxy::createViewWithID()
https://bugs.webkit.org/show_bug.cgi?id=258093
<rdar://110799152>
Reviewed by Chris Dumez.
Stop using WTFMove() on RetainPtr<> to fix the bug.
* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::createLayerWithID):
- Whitespace change to match code structure in createViewWithID().
(WebKit::VideoFullscreenManagerProxy::createViewWithID):
- Stop using WTFMove(playerView) when calling setPlayerView() to fix the
use-after-move.
- Make playerLayer a RetainPtr<> variable and use WTFMove(playerLayer)
when calling setPlayerLayer() to make it match ARC lifetime and avoid
ref count churn.
Canonical link: https://commits.webkit.org/265193@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
