Title: [109286] trunk/Source/WebCore
- Revision
- 109286
- Author
- [email protected]
- Date
- 2012-02-29 17:17:33 -0800 (Wed, 29 Feb 2012)
Log Message
<msubsup> setNeedsLayout() correction
https://bugs.webkit.org/show_bug.cgi?id=79856
Patch by David Barton <[email protected]> on 2012-02-29
Reviewed by Julien Chaffraix.
m_scripts->setNeedsLayout(true, false); needs to be added to the fix for bug 79274.
No new tests. It's actually difficult to test the need for this with the current code,
because there are a lot of extra setNeedsLayout() calls right now. I caught this after
removing some of those calls that should be redundant, for a future patch. Actually
removing those calls now changes other behavior, due to other bugs, so I'll save all
that for future patches. We should land this fix now though I think, as it could
possibly matter in some cases.
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::layout):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (109285 => 109286)
--- trunk/Source/WebCore/ChangeLog 2012-03-01 01:03:41 UTC (rev 109285)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 01:17:33 UTC (rev 109286)
@@ -1,3 +1,22 @@
+2012-02-29 David Barton <[email protected]>
+
+ <msubsup> setNeedsLayout() correction
+ https://bugs.webkit.org/show_bug.cgi?id=79856
+
+ Reviewed by Julien Chaffraix.
+
+ m_scripts->setNeedsLayout(true, false); needs to be added to the fix for bug 79274.
+
+ No new tests. It's actually difficult to test the need for this with the current code,
+ because there are a lot of extra setNeedsLayout() calls right now. I caught this after
+ removing some of those calls that should be redundant, for a future patch. Actually
+ removing those calls now changes other behavior, due to other bugs, so I'll save all
+ that for future patches. We should land this fix now though I think, as it could
+ possibly matter in some cases.
+
+ * rendering/mathml/RenderMathMLSubSup.cpp:
+ (WebCore::RenderMathMLSubSup::layout):
+
2012-02-29 Andreas Kling <[email protected]>
IsSynchronizingStyleAttributeFlag could be purged.
Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp (109285 => 109286)
--- trunk/Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp 2012-03-01 01:03:41 UTC (rev 109285)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp 2012-03-01 01:17:33 UTC (rev 109286)
@@ -183,6 +183,7 @@
superscriptWrapper->style()->setPaddingBottom(Length(superPaddingBottom, Fixed));
superscriptWrapper->setNeedsLayout(true, false);
+ m_scripts->setNeedsLayout(true, false);
RenderBlock::layout();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
