Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c412d338b0081d855291ea6a50724861f97daa1e
https://github.com/WebKit/WebKit/commit/c412d338b0081d855291ea6a50724861f97daa1e
Author: Ahmad Saleem <[email protected]>
Date: 2023-07-04 (Tue, 04 Jul 2023)
Changed paths:
M Source/WebCore/html/HTMLTextAreaElement.h
M Source/WebCore/rendering/RenderTextControlMultiLine.cpp
M Source/WebCore/rendering/RenderTextControlMultiLine.h
Log Message:
-----------
Remove rendererWillBeDestroyed() from HTMLTextAreaElement.h and
RenderTextControlMultiLine.cpp
https://bugs.webkit.org/show_bug.cgi?id=258785
Reviewed by Tim Nguyen.
Merge:
https://chromium.googlesource.com/chromium/blink/+/10c9bbc0ea2c10efe497897cbd12bb842f7b0ee2
This code was added in 2006 in https://trac.webkit.org/changeset/13051
and the test that was added with it fast/forms/textarea-setvalue-submit.html
still passes without the code now. It doesn't make any sense that form
controls would need to do this update in the destructor of the renderer,
especially not only `textarea` since none of the other controls do this.
* Source/WebCore/html/HTMLTextAreaElement.h: Remove 'rendererWillBeDestroyed'
* Source/WebCore/rendering/RenderTextControlMultiLine.cpp:
(RenderTextControlMultiLine::willBeDestroyed): Deleted
* Source/WebCore/rendering/RenderTextControlMultiLine.h: Delete
'willBeDestroyed' definition
Canonical link: https://commits.webkit.org/265755@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
