Title: [109350] trunk/Source/WebKit/chromium
- Revision
- 109350
- Author
- [email protected]
- Date
- 2012-03-01 09:15:03 -0800 (Thu, 01 Mar 2012)
Log Message
REGRESSION(r109288): WebViewImpl::enableAutoResizeMode loops infinitely
https://bugs.webkit.org/show_bug.cgi?id=77452
Reviewed by Hajime Morita.
WebViewImpl::enableAutoResizeMode loops infinitely.
This patch fixes the following line:
enableAutoResizeMode(enable, minSize, maxSize);
to
enableAutoResizeMode(minSize, maxSize);
to avoid the infinite loop. I guess this is the change originally intended.
Test: webkit_unit_tests.WebViewTest.AutoResizeMinimumSize
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enableAutoResizeMode):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (109349 => 109350)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-01 16:34:05 UTC (rev 109349)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-01 17:15:03 UTC (rev 109350)
@@ -1,3 +1,25 @@
+2012-03-01 Kentaro Hara <[email protected]>
+
+ REGRESSION(r109288): WebViewImpl::enableAutoResizeMode loops infinitely
+ https://bugs.webkit.org/show_bug.cgi?id=77452
+
+ Reviewed by Hajime Morita.
+
+ WebViewImpl::enableAutoResizeMode loops infinitely.
+ This patch fixes the following line:
+
+ enableAutoResizeMode(enable, minSize, maxSize);
+
+ to
+ enableAutoResizeMode(minSize, maxSize);
+
+ to avoid the infinite loop. I guess this is the change originally intended.
+
+ Test: webkit_unit_tests.WebViewTest.AutoResizeMinimumSize
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::enableAutoResizeMode):
+
2012-02-29 Kinuko Yasuda <[email protected]>
Use the new createSnapshotFileAndReadMetadata API for FileEntry.file()
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (109349 => 109350)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-03-01 16:34:05 UTC (rev 109349)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-03-01 17:15:03 UTC (rev 109350)
@@ -2282,7 +2282,7 @@
void WebViewImpl::enableAutoResizeMode(bool enable, const WebSize& minSize, const WebSize& maxSize)
{
if (enable)
- enableAutoResizeMode(enable, minSize, maxSize);
+ enableAutoResizeMode(minSize, maxSize);
else
disableAutoResizeMode();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
