Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: df1f3e35c7630153e106ad48a287f9b7ee9b96ea
https://github.com/WebKit/WebKit/commit/df1f3e35c7630153e106ad48a287f9b7ee9b96ea
Author: Richard Robinson <[email protected]>
Date: 2023-07-14 (Fri, 14 Jul 2023)
Changed paths:
M
Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.css
M Source/WebCore/html/HTMLMediaElement.cpp
Log Message:
-----------
Media: media player overlapping with text on daringfireball.net
https://bugs.webkit.org/show_bug.cgi?id=259222
rdar://110986563
Reviewed by Mike Wyrzykowski.
There are two issues causing the overlapping and weird position:
1. When the page scale is < 1, our media controls counter-scaling increases the
size of the media
controls outside their layout size; they should be restricted to their layout
size. 262952@main
tried to fix it, however it was not a complete fix because
`updatePageScaleFactorJSProperty()` is
called in two places and the check for `m_mediaControlsDependOnPageScaleFactor`
was only added in
one of these call sites.
2. All media controls have a `bottom` CSS property applied to them, which
causes an offset to be
applied to the element. However, this was only ever intended to be applied in
non-audio controls.
Fix (1) by simply adding the check in the other call site, and fix (2) by
removing this property
from the audio controls.
*
Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.css:
(.media-controls.vision.fullscreen > .bottom.controls-bar):
(.media-controls.vision > .bottom.controls-bar): Deleted.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::ensureMediaControls):
Canonical link: https://commits.webkit.org/266071@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
