Branch: refs/heads/webkit-2023.4-embargoed Home: https://github.com/WebKit/WebKit Commit: 3601da9e0901444c85f9f2a28e4bd30845ff75b1 https://github.com/WebKit/WebKit/commit/3601da9e0901444c85f9f2a28e4bd30845ff75b1 Author: Jonathan Bedard <[email protected]> Date: 2023-04-17 (Mon, 17 Apr 2023)
Changed paths: Log Message: ----------- Branch point for webkit-2023.4-embargoed Canonical link: https://commits.webkit.org/[email protected] Commit: 3dd204cd088b42010430e50bb1c243806d066457 https://github.com/WebKit/WebKit/commit/3dd204cd088b42010430e50bb1c243806d066457 Author: Rob Buis <[email protected]> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A LayoutTests/fast/scrolling/fixed-positioned-element-update-crash-expected.txt A LayoutTests/fast/scrolling/fixed-positioned-element-update-crash.html Log Message: ----------- Cherry-pick [email protected] (010528ca060e). https://bugs.webkit.org/show_bug.cgi?id=245389 Add crash test for bad update of fixed position scrolling node https://bugs.webkit.org/show_bug.cgi?id=245389 Reviewed by Simon Fraser. This was already fixed with #255114, but add the test for completeness. * LayoutTests/fast/scrolling/fixed-positioned-element-update-crash-expected.txt: Added. * LayoutTests/fast/scrolling/fixed-positioned-element-update-crash.html: Added. Canonical link: https://commits.webkit.org/[email protected] Canonical link: https://commits.webkit.org/[email protected] Commit: e5f02af4cdcb961625c9a050d1c8d5fde4103272 https://github.com/WebKit/WebKit/commit/e5f02af4cdcb961625c9a050d1c8d5fde4103272 Author: Rob Buis <[email protected]> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A LayoutTests/fast/multicol/legend-in-column-outline-auto-crash-expected.txt A LayoutTests/fast/multicol/legend-in-column-outline-auto-crash.html M Source/WebCore/rendering/RenderObject.cpp Log Message: ----------- Cherry-pick [email protected] (e7b0459eaad2). rdar://104813886 Take legend element into account in propagateRepaintToParentWithOutlineAutoIfNeeded https://bugs.webkit.org/show_bug.cgi?id=251381 rdar://104813886 Reviewed by Alan Baradlay. In change r259412 logic was introduced for spanner placeholders and a check was done to see if the previous sibling renderer is a column set. However legends are kept out of column flows and thus may also have a column set as previous sibling, in this case we don't want to enter the spanner placeholder logic. * LayoutTests/fast/multicol/legend-in-column-outline-auto-crash-expected.txt: Added. * LayoutTests/fast/multicol/legend-in-column-outline-auto-crash.html: Added. * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded const): Canonical link: https://commits.webkit.org/[email protected] Canonical link: https://commits.webkit.org/[email protected] Commit: a343fbe5dae881e4b89bf4055950b54e00d52588 https://github.com/WebKit/WebKit/commit/a343fbe5dae881e4b89bf4055950b54e00d52588 Author: Claudio Saavedra <[email protected]> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A LayoutTests/fast/css/content/display-contents-on-focus-crash-expected.txt A LayoutTests/fast/css/content/display-contents-on-focus-crash.html Log Message: ----------- Cherry-pick [email protected] (042db6f5677e). https://bugs.webkit.org/show_bug.cgi?id=251380 Add test for display contents on focus change https://bugs.webkit.org/show_bug.cgi?id=251380 Reviewed by Antti Koivisto. Already fixed by #248776, but add this test for completeness. * LayoutTests/fast/css/content/display-contents-on-focus-crash-expected.txt: Added. * LayoutTests/fast/css/content/display-contents-on-focus-crash.html: Added. Canonical link: https://commits.webkit.org/[email protected] Canonical link: https://commits.webkit.org/[email protected] Commit: dc798091ef4a961a4ada9f77182c2fe8fbb98e50 https://github.com/WebKit/WebKit/commit/dc798091ef4a961a4ada9f77182c2fe8fbb98e50 Author: Rob Buis <[email protected]> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar-expected.txt A LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar.html M Source/WebCore/rendering/RenderBlock.cpp Log Message: ----------- Cherry-pick [email protected] (0a7c35b68439). https://bugs.webkit.org/show_bug.cgi?id=253037 Adapt OOF with specified height case in availableLogicalHeightForPercentageComputation https://bugs.webkit.org/show_bug.cgi?id=253037 Reviewed by Alan Baradlay. The computed height for OOF can result in being zero for certain insets (but never negative). In that case subtracting scrollbar sizes could result in negative values like in the test case, so clamp to zero. * LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar-expected.txt: Added. * LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar.html: Added. * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const): Canonical link: https://commits.webkit.org/[email protected] Canonical link: https://commits.webkit.org/[email protected] Commit: 8efd98eb689f2c3dc6d0d49e7576bf856c30848b https://github.com/WebKit/WebKit/commit/8efd98eb689f2c3dc6d0d49e7576bf856c30848b Author: Rob Buis <[email protected]> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h Log Message: ----------- Cherry-pick [email protected] (0888aabefd69). https://bugs.webkit.org/show_bug.cgi?id=245374 Improve isInsideMulticolumnFlow lambda for top-layer elements https://bugs.webkit.org/show_bug.cgi?id=245374 Reviewed by Alan Baradlay. Improve isInsideMulticolumnFlow lambda for top-layer elements. Top-layer elements can skip many ancestors since the containing block is the RenderView. So instead of checking the fragmentedFlowRoot boundary, check the containing block fragmented flow state. * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::setFragmentedFlowStateIncludingDescendants): (WebCore::RenderObject::initializeFragmentedFlowStateOnInsertion): (WebCore::RenderObject::resetFragmentedFlowStateOnRemoval): * Source/WebCore/rendering/RenderObject.h: Canonical link: https://commits.webkit.org/[email protected] Canonical link: https://commits.webkit.org/[email protected] Commit: c5710a2631d9ff1849545973c5ae10a0c2c6cbf5 https://github.com/WebKit/WebKit/commit/c5710a2631d9ff1849545973c5ae10a0c2c6cbf5 Author: Rob Buis <[email protected]> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A LayoutTests/fast/multicol/crash-when-constructing-nested-columns2-expected.txt A LayoutTests/fast/multicol/crash-when-constructing-nested-columns2.html M Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp Log Message: ----------- Cherry-pick [email protected] (028f984310b6). https://bugs.webkit.org/show_bug.cgi?id=245374 Fix spanner reset logic https://bugs.webkit.org/show_bug.cgi?id=245374 Reviewed by Alan Baradlay. In restoreColumnSpannersForContainer we want to reset the spanners to their original position and remove the placeholders, however in some cases the attach step will call multiColumnDescendantInserted and re-insert placeholders. To fix this, prevent calling the spanner processing logic by multiColumnDescendantInserted by introducing a new flag gRestoringColumnSpannersForContainer. * LayoutTests/fast/multicol/crash-when-constructing-nested-columns2-expected.txt: Added. * LayoutTests/fast/multicol/crash-when-constructing-nested-columns2.html: Added. * Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp: (WebCore::RenderTreeBuilder::MultiColumn::restoreColumnSpannersForContainer): (WebCore::RenderTreeBuilder::MultiColumn::multiColumnDescendantInserted): (WebCore::RenderTreeBuilder::MultiColumn::processPossibleSpannerDescendant): Canonical link: https://commits.webkit.org/[email protected] Canonical link: https://commits.webkit.org/[email protected] Commit: 221c50b850f81ea5d7b200496b5a505953260545 https://github.com/WebKit/WebKit/commit/221c50b850f81ea5d7b200496b5a505953260545 Author: Rob Buis <[email protected]> Date: 2023-04-18 (Tue, 18 Apr 2023) Changed paths: A LayoutTests/fast/media/print-video-crash-expected.txt A LayoutTests/fast/media/print-video-crash.html M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Tools/WebKitTestRunner/TestController.cpp Log Message: ----------- Make sure end printing is handled before PrintFrame https://bugs.webkit.org/show_bug.cgi?id=237291 Reviewed by Chris Dumez. To ensure end printing is handled (and layer tree is unfrozen) introduce a completion handler on EndPrinting and tie its completion to the completion handler in WebPageProxy::printFrame. Also do not call endPrinting from TestController.cpp since WebPageProxy::printFrame takes care of that. * LayoutTests/fast/media/print-video-crash-expected.txt: Added. * LayoutTests/fast/media/print-video-crash.html: Added. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printFrame): (WebKit::WebPageProxy::endPrinting): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::endPrinting): * Source/WebKit/WebProcess/WebPage/WebPage.h: (WebKit::WebPage::endPrinting): (WebKit::WebPage::endPrintingDuringDOMPrintOperation): * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Tools/WebKitTestRunner/TestController.cpp: (WTR::printFrame): Canonical link: https://commits.webkit.org/[email protected] Commit: a0645306d06d3305d01b4976c4ecc3d0fa69f303 https://github.com/WebKit/WebKit/commit/a0645306d06d3305d01b4976c4ecc3d0fa69f303 Author: Rob Buis <[email protected]> Date: 2023-04-24 (Mon, 24 Apr 2023) Changed paths: A LayoutTests/fast/canvas/canvas-print-crash-expected.txt A LayoutTests/fast/canvas/canvas-print-crash.html Log Message: ----------- Add test case for bug 251370 https://bugs.webkit.org/show_bug.cgi?id=251370 Reviewed by Chris Dumez. Already fixed by https://commits.webkit.org/[email protected], but add this test for completeness. * LayoutTests/fast/canvas/canvas-print-crash-expected.txt: Added. * LayoutTests/fast/canvas/canvas-print-crash.html: Added. Canonical link: https://commits.webkit.org/[email protected] Compare: https://github.com/WebKit/WebKit/compare/3601da9e0901%5E...a0645306d06d _______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
