Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a597bab6e4c9cd0ade728c72a7f0dc21d9e4c53c
https://github.com/WebKit/WebKit/commit/a597bab6e4c9cd0ade728c72a7f0dc21d9e4c53c
Author: Wenson Hsieh <[email protected]>
Date: 2023-08-16 (Wed, 16 Aug 2023)
Changed paths:
M Source/WebKit/Platform/spi/ios/UIKitSPI.h
M Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h
M Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm
M Tools/TestWebKitAPI/ios/UIKitSPI.h
Log Message:
-----------
[iOS] Remove several unused SPI method implementations in WKContentView
https://bugs.webkit.org/show_bug.cgi?id=260271
Reviewed by Aditya Keerthi.
Remove a couple of unused SPI method implementations:
```
-[UIWKInteractionViewProtocol
requestRectsToEvadeForSelectionCommandsWithCompletionHandler:]
-[UIWKInteractionViewProtocol selectWordBackward]
```
...as well as an unused SPI method declaration:
```
-[UIWKInteractionViewProtocol clearSelection]
```
* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm:
(-[WKWebView selectWordBackwardForTesting]):
Turn this into a testing-only SPI method, instead of using the SPI declaration
from conforming to
`UIWKInteractionViewProtocol`.
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView
requestPreferredArrowDirectionForEditMenuWithCompletionHandler:]):
(-[WKContentView selectWordBackwardForTesting]):
(-[WKContentView selectWordBackward]): Deleted.
(-[WKContentView
requestRectsToEvadeForSelectionCommandsWithCompletionHandler:]): Deleted.
This method is no longer needed, since iOS 16+ has support for modern edit
menus and uses the method
`-requestPreferredArrowDirectionForEditMenuWithCompletionHandler:` instead.
(-[WKContentView _requestEvasionRectsAboveSelectionIfNeeded:]): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
* Tools/TestWebKitAPI/ios/UIKitSPI.h:
Canonical link: https://commits.webkit.org/266953@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
