Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d72a71047daaf802bc62dea229d53d4faaa668b0
https://github.com/WebKit/WebKit/commit/d72a71047daaf802bc62dea229d53d4faaa668b0
Author: Tim Nguyen <[email protected]>
Date: 2023-08-22 (Tue, 22 Aug 2023)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing.html
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/query/GenericMediaQueryParser.cpp
Log Message:
-----------
[@property] <resolution> should not accept negative resolutions
https://bugs.webkit.org/show_bug.cgi?id=260506
rdar://114235642
Reviewed by Cameron McCormack.
Reject negative resolutions inside consumeResolution &
ResolutionCSSPrimitiveValueWithCalcWithKnownTokenTypeDimensionConsumer as per
the css-values spec.
Also remove the other one-off fixes that were made to reject negative
resolutions, since we now reject them all in a single place now.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing.html:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::ResolutionCSSPrimitiveValueWithCalcWithKnownTokenTypeDimensionConsumer::consume):
(WebCore::CSSPropertyParserHelpers::consumeResolution):
(WebCore::CSSPropertyParserHelpers::consumeImageSetOption):
* Source/WebCore/css/query/GenericMediaQueryParser.cpp:
(WebCore::MQ::GenericMediaQueryParserBase::validateFeatureAgainstSchema):
Canonical link: https://commits.webkit.org/267134@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
