Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5eb9dd27dc3df7998ca679a50fd2b4e27680378e
https://github.com/WebKit/WebKit/commit/5eb9dd27dc3df7998ca679a50fd2b4e27680378e
Author: Sihui Liu <[email protected]>
Date: 2023-08-28 (Mon, 28 Aug 2023)
Changed paths:
A
LayoutTests/fast/speechsynthesis/speech-synthesis-voiceschanged-gc-expected.txt
A LayoutTests/fast/speechsynthesis/speech-synthesis-voiceschanged-gc.html
M Source/WebCore/Modules/speech/SpeechSynthesis.cpp
M Source/WebCore/Modules/speech/SpeechSynthesis.h
M Source/WebCore/Modules/speech/SpeechSynthesis.idl
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
Log Message:
-----------
Make SpeechSynthesis an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=260207
Reviewed by Ryosuke Niwa.
Keep wrapper of SpeechSynthesis alive when voiceschanged event might be fired
and it has event handler.
Test: fast/speechsynthesis/speech-synthesis-voiceschanged-gc.html.
*
LayoutTests/fast/speechsynthesis/speech-synthesis-voiceschanged-gc-expected.txt:
Added.
* LayoutTests/fast/speechsynthesis/speech-synthesis-voiceschanged-gc.html:
Added.
* Source/WebCore/Modules/speech/SpeechSynthesis.cpp:
(WebCore::Ref<SpeechSynthesis>SpeechSynthesis::create):
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::setPlatformSynthesizer):
(WebCore::SpeechSynthesis::voicesDidChange):
(WebCore::SpeechSynthesis::getVoices):
(WebCore::SpeechSynthesis::resumeSynthesis):
(WebCore::SpeechSynthesis::simulateVoicesListChange):
(WebCore::SpeechSynthesis::activeDOMObjectName const):
(WebCore::SpeechSynthesis::virtualHasPendingActivity const):
(WebCore::SpeechSynthesis::eventListenersDidChange):
(WebCore::SpeechSynthesis::resume): Deleted.
* Source/WebCore/Modules/speech/SpeechSynthesis.h:
* Source/WebCore/Modules/speech/SpeechSynthesis.idl:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::simulateSpeechSynthesizerVoiceListChange):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
Canonical link: https://commits.webkit.org/267385@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
