Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b9aa388ebdc7691c99f02701fef1177a8e952789
https://github.com/WebKit/WebKit/commit/b9aa388ebdc7691c99f02701fef1177a8e952789
Author: Tim Nguyen <[email protected]>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-values/mod-length-degrees-crash.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-values/rem-length-degrees-crash.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-length-degrees-crash.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-invalid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-invalid.html
M Source/WebCore/css/calc/CSSCalcOperationNode.cpp
Log Message:
-----------
REGRESSION(267072@main): round/mod/rem crashes when combining length &
non-percentage units
https://bugs.webkit.org/show_bug.cgi?id=260941
rdar://114695951
Reviewed by Cameron McCormack.
The previous code assumed that the second type always would be a percentage,
which is not necessarily true.
`calc(mod(0px, 0deg))` is an example where the current code fails.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-values/mod-length-degrees-crash.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-values/rem-length-degrees-crash.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-length-degrees-crash.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-invalid-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-invalid.html:
* Source/WebCore/css/calc/CSSCalcOperationNode.cpp:
(WebCore::resolvedTypeForStep):
Canonical link: https://commits.webkit.org/267485@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
