Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1a615c7e8bc035090660e4ce098d3dea0388e069
https://github.com/WebKit/WebKit/commit/1a615c7e8bc035090660e4ce098d3dea0388e069
Author: Kimmo Kinnunen <[email protected]>
Date: 2023-09-06 (Wed, 06 Sep 2023)
Changed paths:
M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h
Log Message:
-----------
RemoteDisplayListRecorder uses ThreadSafeWeakPtr to ImageBuffer redundantly
https://bugs.webkit.org/show_bug.cgi?id=261167
rdar://114994553
Reviewed by Antti Koivisto.
The weak ptr was never checked for null, so it wasn't expected to function
as vehicle to detect destruction.
There is no circular dependency between the ImageBuffer and the recorder,
so just use normal Ref.
The image buffer will anyway outlive the recorder, as the recorder is always
removed from the instance list before the RemoteImageBuffers.
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
(WebKit::RemoteDisplayListRecorder::convertToLuminanceMask):
(WebKit::RemoteDisplayListRecorder::transformToColorSpace):
(WebKit::RemoteDisplayListRecorder::flushContext):
(WebKit::RemoteDisplayListRecorder::flushContextSync):
(WebKit::RemoteDisplayListRecorder::drawingContext): Deleted.
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h:
(WebKit::RemoteDisplayListRecorder::drawingContext):
Canonical link: https://commits.webkit.org/267664@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
