Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e4ab69bd8f2b884468da81c4ed52a3b86fc2c34
      
https://github.com/WebKit/WebKit/commit/7e4ab69bd8f2b884468da81c4ed52a3b86fc2c34
  Author: Youenn Fablet <[email protected]>
  Date:   2023-09-06 (Wed, 06 Sep 2023)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any.worker-expected.txt
    M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp
    M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp

  Log Message:
  -----------
  WebCodecs VideoEncoder configure should resolve its promise for unknown codecs
https://bugs.webkit.org/show_bug.cgi?id=260853
rdar://problem/114622760

Reviewed by Jean-Yves Avenard.

Update implementation according latest spec to resolve the isConfigureSupported 
with supported equal to false.
Update implementation according latest spec to close the encoder in case of 
configuring with an unknown/invalid codec.

We more tightly align when we set m_isMessageQueueBlocked to true and false in 
the case when configure fails and we close the encoder/decoder.
Although this is not observable, this more closely aligns with the spec steps.

Covered by updated tests.

* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any.worker-expected.txt:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp:
(WebCore::isValidDecoderConfig):
(WebCore::WebCodecsVideoDecoder::configure):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp:
(WebCore::isSupportedEncoderCodec):
(WebCore::isValidEncoderConfig):
(WebCore::WebCodecsVideoEncoder::configure):
(WebCore::WebCodecsVideoEncoder::isConfigSupported):

Canonical link: https://commits.webkit.org/267668@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to