Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd43b23ea3828af0267e2b1b8366886913535751
      
https://github.com/WebKit/WebKit/commit/fd43b23ea3828af0267e2b1b8366886913535751
  Author: Kimmo Kinnunen <kkinnu...@apple.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp

  Log Message:
  -----------
  WebGLRenderingContextBase::create checks for webGLEnabled setting 
unneccessarily
https://bugs.webkit.org/show_bug.cgi?id=261398
rdar://problem/115273142

Reviewed by Antti Koivisto.

Remove the checks, the check is done in the caller.

For offscreen canvas, one of the checks would ref nullptr if the caller
did not do the check.

It is not right to send the webglcontextcreationerror if the setting is
disabled. When the setting is disabled, it should behave as if WebGL
was not implemented.

* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create):

Canonical link: https://commits.webkit.org/267859@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to