Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f33e99829e4f572a15eb8c2a6ca3d78fa227e9cc
https://github.com/WebKit/WebKit/commit/f33e99829e4f572a15eb8c2a6ca3d78fa227e9cc
Author: Ryosuke Niwa <[email protected]>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M Source/WebCore/bindings/js/ScriptController.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/ScriptDisallowedScope.h
M Source/WebCore/dom/ScriptElement.cpp
Log Message:
-----------
New test added in 265747@main hits assertion failure:
ScriptDisallowedScope::InMainThread::isScriptAllowed()
https://bugs.webkit.org/show_bug.cgi?id=261305
Reviewed by Chris Dumez.
Disable these assertions in WebKit1 as we've done elsewhere.
* Source/WebCore/bindings/js/ScriptController.cpp:
(WebCore::ScriptController::canExecuteScripts): Removed the check for
isInWebProcess given
InMainThread::isScriptAllowed now checks that condition.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::dispatchFocusInEventIfNeeded): Ditto.
(WebCore::Element::dispatchFocusOutEventIfNeeded): Ditto.
* Source/WebCore/dom/ScriptDisallowedScope.h:
(WebCore::ScriptDisallowedScope::InMainThread::isEventDispatchAllowedInSubtree):
Ditto.
(WebCore::ScriptDisallowedScope::InMainThread::isScriptAllowed): Make this
function always return true in
WebKit1 to avoid hitting assertion failures.
* Source/WebCore/dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeClassicScript): Ditto for removing the check
for isInWebProcess.
Canonical link: https://commits.webkit.org/267935@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
