Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e8585e2a185b30c39a2821360714a5b157bec1e0
https://github.com/WebKit/WebKit/commit/e8585e2a185b30c39a2821360714a5b157bec1e0
Author: Tadeu Zagallo <[email protected]>
Date: 2023-10-05 (Thu, 05 Oct 2023)
Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/MangleNames.cpp
Log Message:
-----------
[WGSL] Incomplete function visiting in name mangling and global rewriting
https://bugs.webkit.org/show_bug.cgi?id=262621
rdar://116466577
Reviewed by Mike Wyrzykowski.
Both the name mangling pass and the global rewring pass were not visiting
function
attributes. In order to make it less error prone, I changed it to use thet
default
AST::Visitor implementation. Unfortunatelly, I couldn't find a way to test it
with
our current infrastructure, but it's easily reproducible in the samples whenever
there is an override variable being used in the workgroup_size attribute.
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visit):
* Source/WebGPU/WGSL/MangleNames.cpp:
(WGSL::NameManglerVisitor::visit):
Canonical link: https://commits.webkit.org/268904@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
