Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7b193c245074e736d83051b75490e4e6dfe0baa1
https://github.com/WebKit/WebKit/commit/7b193c245074e736d83051b75490e4e6dfe0baa1
Author: Simon Fraser <[email protected]>
Date: 2023-10-05 (Thu, 05 Oct 2023)
Changed paths:
M Source/WebCore/platform/ScrollView.cpp
M Source/WebCore/platform/ScrollView.h
M Source/WebCore/platform/Widget.cpp
Log Message:
-----------
ScrollView::convertChildToSelf / convertSelfToChild fail to take top content
inset into account
https://bugs.webkit.org/show_bug.cgi?id=262585
rdar://116430905
Reviewed by Tim Horton.
ScrollView::convertChildToSelf() and convertSelfToChild() offset the point by
the scroll position, but this
fails to take top content inset, and left-side scrollbars into account.
This code path isn't hit in general browsing, but future PDF plugin code needs
it to work.
Move the implementations to the .cpp file, and use
documentScrollPositionRelativeToViewOrigin()
instead of scrollPosition(). Pass the points by value.
* Source/WebCore/platform/ScrollView.cpp:
(WebCore::ScrollView::convertChildToSelf const):
(WebCore::ScrollView::convertSelfToChild const):
* Source/WebCore/platform/ScrollView.h:
(WebCore::ScrollView::convertChildToSelf const): Deleted.
(WebCore::ScrollView::convertSelfToChild const): Deleted.
* Source/WebCore/platform/Widget.cpp:
(WebCore::Widget::convertFromContainingView const): auto
(WebCore::Widget::convertToContainingView const): auto
Canonical link: https://commits.webkit.org/268942@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
