Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 272fd33e2ef9cde8de2f097023e9cf2c1d6b3c6e
https://github.com/WebKit/WebKit/commit/272fd33e2ef9cde8de2f097023e9cf2c1d6b3c6e
Author: Chris Dumez <[email protected]>
Date: 2023-10-06 (Fri, 06 Oct 2023)
Changed paths:
M Source/WebCore/dom/Node.cpp
M Source/WebCore/dom/Node.h
Log Message:
-----------
Regression: ASSERT(!m_adoptionIsRequired) under Node::ref() on iOS Debug
https://bugs.webkit.org/show_bug.cgi?id=262764
Reviewed by Ryosuke Niwa.
With smart pointer adoption, it is really easy to ref a Node while it is
still being constructed. This is not harmful but this hits the
adoptionRequirement assertion in Node::ref().
To address the issue, I am relaxing the adoption requirement for Document
Nodes. We may want to extend this to more Node types in the future but
this is enough to address this particular crash.
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::Node):
* Source/WebCore/dom/Node.h:
(WebCore::Node::relaxAdoptionRequirement):
Canonical link: https://commits.webkit.org/268983@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
