Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ac998d7f35a3ab87cf5d3f551d79214b62fdee6
https://github.com/WebKit/WebKit/commit/5ac998d7f35a3ab87cf5d3f551d79214b62fdee6
Author: Youenn Fablet <[email protected]>
Date: 2023-10-11 (Wed, 11 Oct 2023)
Changed paths:
M Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp
M Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.h
Log Message:
-----------
WebKit MediaRecorderPrivate should not be refcounted
https://bugs.webkit.org/show_bug.cgi?id=262945
rdar://problem/116726041
Reviewed by Alex Christensen and Chris Dumez.
Given MediaRecorderPrivate is stored as a std::unique_ptr, it is best to not
ref/deref.
Instead MediaRecorderPrivate stores a ref counted object that is observing
GPUProcess connection closure.
* Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
(WebKit::MediaRecorderPrivate::MediaRecorderPrivate):
(WebKit::MediaRecorderPrivate::startRecording):
(WebKit::MediaRecorderPrivate::gpuProcessConnectionDidClose):
* Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
Canonical link: https://commits.webkit.org/269195@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
