Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc17de89a5223e74e8d66039b546535e6c6b7434
      
https://github.com/WebKit/WebKit/commit/dc17de89a5223e74e8d66039b546535e6c6b7434
  Author: Wenson Hsieh <[email protected]>
  Date:   2023-10-17 (Tue, 17 Oct 2023)

  Changed paths:
    M Tools/TestRunnerShared/spi/UIKitSPIForTesting.h
    M Tools/TestWebKitAPI/ios/mainIOS.mm
    M Tools/WebKitTestRunner/ios/mainIOS.mm

  Log Message:
  -----------
  [iOS] Suppress excessive logging due to calling into 
`-[UITextInteractionAssistant selectionView]` in API tests
https://bugs.webkit.org/show_bug.cgi?id=263266

Reviewed by Aditya Keerthi.

Swizzle out `-[UITextInteractionAssistant selectionView]` to return `nil` 
without added logging.
When `UIKit/redesigned_text_cursor` is enabled, this method already returns 
`nil` anyways, and
the feature flag is enabled by default everywhere where 
`HAVE(UI_TEXT_SELECTION_DISPLAY_INTERACTION)`
is set.

* Tools/TestRunnerShared/spi/UIKitSPIForTesting.h:
* Tools/TestWebKitAPI/ios/mainIOS.mm:
(overrideSelectionViewToSuppressLogging):
(main):
* Tools/WebKitTestRunner/ios/mainIOS.mm:
(overrideSelectionViewToSuppressLogging):
(main):

Canonical link: https://commits.webkit.org/269422@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to