Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 386d03be6b4ccf4193db9ee540a2d292146ded3d
https://github.com/WebKit/WebKit/commit/386d03be6b4ccf4193db9ee540a2d292146ded3d
Author: Chris Dumez <[email protected]>
Date: 2023-10-17 (Tue, 17 Oct 2023)
Changed paths:
A LayoutTests/fast/svg/path-element-d-attribute-crash-expected.txt
A LayoutTests/fast/svg/path-element-d-attribute-crash.html
M Source/WebCore/svg/SVGPathElement.cpp
Log Message:
-----------
Regression(269372@main) Crash under SVGPathElement::attributeChanged()
https://bugs.webkit.org/show_bug.cgi?id=263288
rdar://117091905
Reviewed by Ryosuke Niwa.
Add a fast path for when the `d` attribute value is empty instead of trying
to look up the value in the cache. The crash was due to trying to look up
a null AtomString in the Cache when the attribute gets removed.
* LayoutTests/fast/svg/path-element-d-attribute-crash-expected.txt: Added.
* LayoutTests/fast/svg/path-element-d-attribute-crash.html: Added.
* Source/WebCore/svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::attributeChanged):
Canonical link: https://commits.webkit.org/269431@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
