Title: [109749] trunk/Tools
- Revision
- 109749
- Author
- [email protected]
- Date
- 2012-03-05 08:26:55 -0800 (Mon, 05 Mar 2012)
Log Message
[BlackBerry] Update Tools/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=80287
Reviewed by Antonio Gomes.
Update so we are sure we can build our implementation of DRT.
* DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
* DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
* DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
(AccessibilityController::addNotificationListener): add missing hook.
(AccessibilityController::removeNotificationListener): add missing hook.
* DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
(AccessibilityUIElement::isSelectedOptionActive): add missing hook.
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
(LayoutTestController::simulateDesktopNotificationClick): add missing hook.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (109748 => 109749)
--- trunk/Tools/ChangeLog 2012-03-05 15:52:16 UTC (rev 109748)
+++ trunk/Tools/ChangeLog 2012-03-05 16:26:55 UTC (rev 109749)
@@ -1,3 +1,23 @@
+2012-03-05 Rob Buis <[email protected]>
+
+ [BlackBerry] Update Tools/DumpRenderTree
+ https://bugs.webkit.org/show_bug.cgi?id=80287
+
+ Reviewed by Antonio Gomes.
+
+ Update so we are sure we can build our implementation of DRT.
+
+ * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
+ * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
+ * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
+ (AccessibilityController::addNotificationListener): add missing hook.
+ (AccessibilityController::removeNotificationListener): add missing hook.
+ * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
+ (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
+ * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
+ (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
+ (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
+
2012-03-05 No'am Rosenthal <[email protected]>
[Qt] [WK2] Support threaded renderer in WK2
Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.h (109748 => 109749)
--- trunk/Tools/DumpRenderTree/DumpRenderTree.h 2012-03-05 15:52:16 UTC (rev 109748)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.h 2012-03-05 16:26:55 UTC (rev 109749)
@@ -44,6 +44,8 @@
#include "DumpRenderTreeWx.h"
#elif PLATFORM(EFL)
#include "DumpRenderTreeEfl.h"
+#elif PLATFORM(BLACKBERRY)
+#include "DumpRenderTreeBlackBerry.h"
#endif
#include <string>
Modified: trunk/Tools/DumpRenderTree/PixelDumpSupport.cpp (109748 => 109749)
--- trunk/Tools/DumpRenderTree/PixelDumpSupport.cpp 2012-03-05 15:52:16 UTC (rev 109748)
+++ trunk/Tools/DumpRenderTree/PixelDumpSupport.cpp 2012-03-05 16:26:55 UTC (rev 109749)
@@ -41,6 +41,8 @@
#include "PixelDumpSupportCG.h"
#elif USE(CAIRO)
#include "PixelDumpSupportCairo.h"
+#elif PLATFORM(BLACKBERRY)
+#include "PixelDumpSupportBlackBerry.h"
#endif
void dumpWebViewAsPixelsAndCompareWithExpected(const std::string& expectedHash)
Modified: trunk/Tools/DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp (109748 => 109749)
--- trunk/Tools/DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp 2012-03-05 15:52:16 UTC (rev 109748)
+++ trunk/Tools/DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp 2012-03-05 16:26:55 UTC (rev 109749)
@@ -68,13 +68,12 @@
notImplemented();
}
-void AccessibilityController::addNotificationListener(PlatformUIElement, JSObjectRef)
+bool AccessibilityController::addNotificationListener(JSObjectRef)
{
- notImplemented();
+ return false;
}
-void AccessibilityController::notificationReceived(PlatformUIElement, const std::string&)
+void AccessibilityController::removeNotificationListener()
{
- notImplemented();
}
Modified: trunk/Tools/DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp (109748 => 109749)
--- trunk/Tools/DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp 2012-03-05 15:52:16 UTC (rev 109748)
+++ trunk/Tools/DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp 2012-03-05 16:26:55 UTC (rev 109749)
@@ -508,6 +508,12 @@
return false;
}
+bool AccessibilityUIElement::isSelectedOptionActive() const
+{
+ notImplemented();
+ return false;
+}
+
bool AccessibilityUIElement::isVisible() const
{
notImplemented();
Modified: trunk/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp (109748 => 109749)
--- trunk/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp 2012-03-05 15:52:16 UTC (rev 109748)
+++ trunk/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp 2012-03-05 16:26:55 UTC (rev 109749)
@@ -897,3 +897,11 @@
{
}
+void LayoutTestController::setMockSpeechInputDumpRect(bool)
+{
+}
+
+void LayoutTestController::simulateDesktopNotificationClick(JSStringRef title)
+{
+}
+
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
