Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2b4d9ac4ad7211b883b024bd21450d0dbbf36fce
https://github.com/WebKit/WebKit/commit/2b4d9ac4ad7211b883b024bd21450d0dbbf36fce
Author: Ahmad Saleem <[email protected]>
Date: 2023-10-23 (Mon, 23 Oct 2023)
Changed paths:
M Source/WebCore/xml/parser/XMLDocumentParser.h
M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
Log Message:
-----------
Remove 'libxml2' hacks called 'hackAroundLibXMLEntityBug' and
'hackAroundLibXMLEntityParsingBug'
https://bugs.webkit.org/show_bug.cgi?id=263497
Reviewed by Don Olmstead, David Kilzer and Michael Catanzaro.
Inspired by:
https://src.chromium.org/viewvc/blink?view=revision&revision=149452 &
https://src.chromium.org/viewvc/blink?view=revision&revision=149412
This patch removes old hacks to workaround `libxml2` bugs, which are no longer
applicable.
These underlying bugs were fixed in upstream `libxml2` in following versions:
- hackAroundLibXMLEntityBug (fixed in 2.6.27)
- hackAroundLibXMLEntityParsingBug (fixed in 2.7.3)
All WebKit ports (via CMake) support following libxml2 version as required:
- mac (2.8.0 as required)
- Windows & Playstation (2.9.7 as required)
- WPE (2.8.0 as required)
- GTK (2.8.0 as required)
* Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
(hackAroundLibXMLEntityParsingBug): Deleted
(XMLDocumentParser::startElementNs): Clean-up after 'function' deletion
(XMLDocumentParser::endElementNs): Ditto
(hackAroundLibXMLEntityBug): Deleted
(startElementNsHandler): Clean-up after 'function' deletion
(endElementNsHandler): Ditto
(charactersHandler): Ditto
(processingInstructionHandler): Ditto
(cdataBlockHandler): Ditto
(commentHandler): Ditto
(entityDeclarationHandler): Deleted
(getEntityHandler): Clean-up after 'function' deletion
(XMLDocumentParser::initializeParserContext): Ditto
* Source/WebCore/xml/parser/XMLDocumentParser.h: Remove unused functions after
clean-up
Canonical link: https://commits.webkit.org/269666@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes