Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 08528dc43d175d5c969dcfdcda6731e97f4763be
https://github.com/WebKit/WebKit/commit/08528dc43d175d5c969dcfdcda6731e97f4763be
Author: Timothy Hatcher <[email protected]>
Date: 2023-10-24 (Tue, 24 Oct 2023)
Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm
M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h
M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm
Log Message:
-----------
WebExtension::actionIcon needs to fallback to WebExtension::icon.
https://webkit.org/b/263561
rdar://problem/117377423
Reviewed by Brian Weinstein and Brady Eidson.
This is the documented behavior of -[_WkWebExtension actionIconForSize:], just
didn't do it.
"If no matching [action] icon is available, the method will fall back to the
extension's icon."
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::actionIcon):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm:
(TestWebKitAPI::TEST):
(TestWebKitAPI::makePNGData): Deleted.
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h:
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(TestWebKitAPI::Util::makePNGData):
Canonical link: https://commits.webkit.org/269705@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
