Branch: refs/heads/safari-7616.2.9.10-branch
Home: https://github.com/WebKit/WebKit
Commit: fc339e34235982fbe291bead68134ee5a4fae144
https://github.com/WebKit/WebKit/commit/fc339e34235982fbe291bead68134ee5a4fae144
Author: Myah Cobbs <[email protected]>
Date: 2023-09-28 (Thu, 28 Sep 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7616.2.9.10.1
Identifier: [email protected]
Commit: 770aa9561cdd7a64c8f76fc9ec639de7a7fa263c
https://github.com/WebKit/WebKit/commit/770aa9561cdd7a64c8f76fc9ec639de7a7fa263c
Author: Wenson Hsieh <[email protected]>
Date: 2023-09-28 (Thu, 28 Sep 2023)
Changed paths:
M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h
M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm
Log Message:
-----------
Cherry-pick f7bf40970a7b. rdar://115081644
Add a quirk for accounts.google.com for the third party IP cookie expiry
capping heuristic
https://bugs.webkit.org/show_bug.cgi?id=262062
rdar://115081644
Reviewed by John Wilander and Charlie Wolfe.
This patch:
1. Adds a quirk to avoid treating requests to `accounts.google.com` as
being from a third party IP
*only under google.com*, for the purposes of applying 7-day expiry
restrictions on incoming
cookies.
2. Contains various cleanup around the `NetworkTaskCocoa.mm` file:
- Add a missing `namespace WebKit` around the implementation file,
and moves the existing
`using namespace WebCore` behind the WebKit namespace.
- Add missing source includes (which are currently not necessary, due
to unified sources).
- Consistently use `#import` throughout this Cocoa-specific header
and implementation file.
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm:
(WebKit::NetworkTaskCocoa::applyCookiePolicyForThirdPartyCloaking):
Add the quirk; note that we only need to check the host of the requested
URL here, because we only
get to this codepath in the case where the request is already a first party
subdomain of google.com.
(computeIsAlwaysOnLoggingAllowed): Deleted.
(NetworkTaskCocoa::NetworkTaskCocoa): Deleted.
(shouldCapCookieExpiryForThirdPartyIPAddress): Deleted.
(NetworkTaskCocoa::shouldApplyCookiePolicyForThirdPartyCloaking const):
Deleted.
(NetworkTaskCocoa::statelessCookieStorage): Deleted.
(NetworkTaskCocoa::lastRemoteIPAddress): Deleted.
(NetworkTaskCocoa::lastCNAMEDomain): Deleted.
(NetworkTaskCocoa::needsFirstPartyCookieBlockingLatchModeQuirk const):
Deleted.
(NetworkTaskCocoa::applyCookiePolicyForThirdPartyCloaking): Deleted.
(NetworkTaskCocoa::blockCookies): Deleted.
(NetworkTaskCocoa::unblockCookies): Deleted.
(NetworkTaskCocoa::updateTaskWithFirstPartyForSameSiteCookies): Deleted.
(NetworkTaskCocoa::willPerformHTTPRedirection): Deleted.
Canonical link: https://commits.webkit.org/268423@main
Identifier: [email protected]
Commit: b50bdd153d15b932ba199680fcdf21fa8df7b21d
https://github.com/WebKit/WebKit/commit/b50bdd153d15b932ba199680fcdf21fa8df7b21d
Author: Jer Noble <[email protected]>
Date: 2023-09-28 (Thu, 28 Sep 2023)
Changed paths:
A LayoutTests/fast/scrolling/ios/video-scrolling-expected.txt
A LayoutTests/fast/scrolling/ios/video-scrolling.html
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm
A Source/WebKit/UIProcess/ios/WKVideoView.h
A Source/WebKit/UIProcess/ios/WKVideoView.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
Cherry-pick 960e0d109099. rdar://114720841
[iOS] Cannot scroll page by dragging on a bare <video> element
https://bugs.webkit.org/show_bug.cgi?id=261563
rdar://114720841
Reviewed by Simon Fraser.
The UI-side compositing subsystem relies on UIViews of particular classes
or conforming to
particular protocols for collecting the appropriate views during hit
testing. WebAVPlayerLayerView
is not one of those clasess, nor can it conform to the protocols defined in
WebKit (as it's a
product of WebCore). So to the hit testing logic of UI-side compositing,
it's a black hole.
Add a new class, WKVideoView, which is a WKCompositingView as well as
WKNativelyInteractible, to
host the WebAVPlayerLayerView.
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::createViewWithID):
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
* Source/WebKit/UIProcess/ios/WKVideoView.h: Added.
* Source/WebKit/UIProcess/ios/WKVideoView.mm: Added.
(+[WKVideoView layerClass]):
(-[WKVideoView hitTest:withEvent:]):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/268041@main
Identifier: [email protected]
Commit: c2b9f127d8379febf44f6d1df239a636d55561ea
https://github.com/WebKit/WebKit/commit/c2b9f127d8379febf44f6d1df239a636d55561ea
Author: Sammy Gill <[email protected]>
Date: 2023-09-28 (Thu, 28 Sep 2023)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-areas-valid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid.html
M Source/WebCore/css/ShorthandSerializer.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
Log Message:
-----------
Cherry-pick 74849b01b119. rdar://115862393
Directly check values of grid-template-rows and grid-template-columns when
serializing grid-template with grid areas
https://bugs.webkit.org/show_bug.cgi?id=260494
rdar://114224504
Reviewed by Tim Nguyen.
The grid-template shorthand has two different options for its syntax:
- [ <'grid-template-rows'> / <'grid-template-columns'> ]
- [ <line-names>? <string> <track-size>? <line-names>? ]+ [ /
<explicit-track-list> ]?
In the latter version of the syntax, ShorthandSerializer would bail out
early (and not serialize any values) if grid-template-areas (the <string>
portion of the syntax) was not set by the grid-template shorthand. We
should instead check the values of grid-template-rows and
grid-template-columns
directly to see if they can be expressed inside of this shorthand.
For the rows portion we build up the shorthand iteratively, so we can
just check if the value is a valid <track-size> and return an empty
string if it is not since that would mean the value could not be
expressed in the shorthand. A value being a valid <track-size> means that
it must be one of: minmax(), fit-content(), length-percentage, flex,
min-content, max-content, or auto. If it is not one of these then the
value is not a <track-size>.
For the columns portion we have to check the entire value of
grid-template-columns
beforehand since we will end up appending the whole value to the end
of the shorthand. To check to see if a value is a valid
<explicit-track-list>,
we need to make sure the value contains only <line-names>s and <track-size>s
with at least one <track-size> in the value.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-areas-valid-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid.html:
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::commonSerializationChecks):
(WebCore::ShorthandSerializer::serializeGridTemplate const):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::isGridBreadthIdent):
(WebCore::CSSPropertyParserHelpers::consumeGridBreadth):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
Canonical link: https://commits.webkit.org/267155@main
Identifier: [email protected]
Commit: e656aef4b5c8119a63065ff4c21dd633382020cd
https://github.com/WebKit/WebKit/commit/e656aef4b5c8119a63065ff4c21dd633382020cd
Author: Myah Cobbs <[email protected]>
Date: 2023-09-28 (Thu, 28 Sep 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7616.2.9.10.2
Identifier: [email protected]
Commit: 711b75e7b04514e15581198ae63437b10ad9eb47
https://github.com/WebKit/WebKit/commit/711b75e7b04514e15581198ae63437b10ad9eb47
Author: Jer Noble <[email protected]>
Date: 2023-09-28 (Thu, 28 Sep 2023)
Changed paths:
M Source/WebKit/UIProcess/ios/WKVideoView.h
Log Message:
-----------
Cherry-pick f64be53a5d37. rdar://114720841
[iOS] REGRESSION(268041@main): Unable to scroll Twitch.tv with touch atop
video area
https://bugs.webkit.org/show_bug.cgi?id=261950
rdar://115850939
Reviewed by Simon Fraser.
Views which conform to WKNativelyInteractible (like WKModelView and
WKSegmentedModelView) get special treatment inside
`-_web_findDescendantViewAtPoint:`, so that touch events can be handled
directly by the view itself. WKVideoView doesn't actually need to handle touch
events directly, so it should just be a normal subclass of WKCompositingView.
* Source/WebKit/UIProcess/ios/WKVideoView.h:
Canonical link: https://commits.webkit.org/268331@main
Identifier: [email protected]
Commit: c05072b6d358b12bffa114c8a1e8351739bb5235
https://github.com/WebKit/WebKit/commit/c05072b6d358b12bffa114c8a1e8351739bb5235
Author: Jer Noble <[email protected]>
Date: 2023-09-28 (Thu, 28 Sep 2023)
Changed paths:
A LayoutTests/fast/scrolling/ios/video-scrolling-with-overflow-expected.txt
A LayoutTests/fast/scrolling/ios/video-scrolling-with-overflow.html
M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm
Log Message:
-----------
Cherry-pick 7fa44a650d9a. rdar://114720841
[iOS] Cannot scroll page by dragging on a bare <video> element
https://bugs.webkit.org/show_bug.cgi?id=261563
rdar://114720841
Reviewed by Eric Carlson.
Hit testing in the WebKit utility method isScrolledBy() works by walking up
the view heirarchy looking for a view which return a valid node from
RemoteLayerTreeNode::forCALayer(). However, while WKLayerHostView is a subview
of WebAVPlayerLayerView, it's superview property is nil. This occurs because
while the WKLayerHostView.layer is made a sublayer of the
WebAVPlayerLayerView.playerLayer, the WKLayerHostView itself is not made a
subview of the WebAVPlayerLayerView.
Drive-by fix: in testing this patch, a crash will occasionally occur where
a null pointer is dereferenced in collectDescendantViewsAtPoint(). Add a null
check and return false if that check fails.
*
LayoutTests/fast/scrolling/ios/video-scrolling-with-overflow-expected.txt:
Added.
* LayoutTests/fast/scrolling/ios/video-scrolling-with-overflow.html: Added.
* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::createViewWithID):
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
(WebKit::collectDescendantViewsAtPoint):
Canonical link: https://commits.webkit.org/268566@main
Identifier: [email protected]
Commit: 1a35d49fb32c05d437f08091513acf813fa57553
https://github.com/WebKit/WebKit/commit/1a35d49fb32c05d437f08091513acf813fa57553
Author: Dan Robson <[email protected]>
Date: 2023-10-02 (Mon, 02 Oct 2023)
Changed paths:
M .submitproject
Log Message:
-----------
Cherry-pick 9873b33d379d. rdar://116351575
Update .submitproject
rdar://116351575
Reviewed by Alexey Proskuryakov.
Configurations/ directory is required to build.
* .submitproject:
Canonical link: https://commits.webkit.org/268735@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: 226a2b8a8e01c23c795e926c0dd4507a45e5c7b9
https://github.com/WebKit/WebKit/commit/226a2b8a8e01c23c795e926c0dd4507a45e5c7b9
Author: Dan Robson <[email protected]>
Date: 2023-10-02 (Mon, 02 Oct 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7616.2.9.10.3
Canonical link: https://commits.webkit.org/[email protected]
Commit: 14f55f527dd84451552009b959587d274195ecb7
https://github.com/WebKit/WebKit/commit/14f55f527dd84451552009b959587d274195ecb7
Author: Dan Robson <[email protected]>
Date: 2023-10-02 (Mon, 02 Oct 2023)
Changed paths:
M
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c
Log Message:
-----------
Cherry-pick 2213bac36f8b. rdar://116372865
Cherry-pick
https://chromium.googlesource.com/webm/libvpx.git/+/51057f4ba894e13f9bba278905bacf6aaaecd992
https://bugs.webkit.org/show_bug.cgi?id=262365
rdar://116233358
Reviewed by Mark Lam.
*
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp8/encoder/onyx_if.c:
(vp8_change_config):
Canonical link: https://commits.webkit.org/267815.127@safari-7617-branch
Canonical link: https://commits.webkit.org/[email protected]
Commit: b44d0deb64e50c227b3b354715b029d67a0f0cb6
https://github.com/WebKit/WebKit/commit/b44d0deb64e50c227b3b354715b029d67a0f0cb6
Author: Dan Robson <[email protected]>
Date: 2023-10-03 (Tue, 03 Oct 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7616.2.9.10.4
Canonical link: https://commits.webkit.org/[email protected]
Commit: 6de839091b9f8b8a923947851e7bbe04c02b86b3
https://github.com/WebKit/WebKit/commit/6de839091b9f8b8a923947851e7bbe04c02b86b3
Author: Dan Robson <[email protected]>
Date: 2023-10-03 (Tue, 03 Oct 2023)
Changed paths:
M
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/test/resize_test.cc
M
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/common/vp9_alloccommon.c
M
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_encoder.c
Log Message:
-----------
Cherry-pick 505f26eea3a5. rdar://116293231
VP9 additional changes related to CVE-2023-5217
rdar://116293231
Reviewed by Jean-Yves Avenard.
Cherry-picking patches that do hardening of VP9 encoder reconfiguration:
- 02ab555e992c191e5c509ed87b3cc48ed915b447
- 263682c9a29395055f3b3afe2d97be1828a6223f
I had to update CHECK_MEM_ERROR call site since we need to pass cm
currently, while they do pass cm->error upstream.
While we do not think we are exercising this code path of reconfiguring
while encoding,
it is future proof and low risk to cherry-pick these changes.
*
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/test/resize_test.cc:
*
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/common/vp9_alloccommon.c:
(free_seg_map):
(vp9_free_context_buffers):
(vp9_alloc_context_buffers):
*
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vp9/encoder/vp9_encoder.c:
(free_copy_partition_data):
(vp9_change_config):
Canonical link: https://commits.webkit.org/267815.170@safari-7617-branch
Canonical link: https://commits.webkit.org/[email protected]
Commit: 4db484b7782eff83eddabe99e3dc860cdb6445c5
https://github.com/WebKit/WebKit/commit/4db484b7782eff83eddabe99e3dc860cdb6445c5
Author: Dan Robson <[email protected]>
Date: 2023-10-04 (Wed, 04 Oct 2023)
Changed paths:
M
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm
Log Message:
-----------
Cherry-pick 53867c15edf3. rdar://115712997
setSampleBufferAsDisplayImmediately should check that attachment array is
not null
https://bugs.webkit.org/show_bug.cgi?id=262556
rdar://115712997
Reviewed by Brent Fulgham.
CMSampleBufferGetSampleAttachmentsArray may return a null attachment array
even if createIfNecessary = true, in case of error.
In that case, make sure setSampleBufferAsDisplayImmediately bails out early.
*
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
(WebCore::setSampleBufferAsDisplayImmediately):
Canonical link: https://commits.webkit.org/268802@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: a9a7da1667817922c7356d64af9d36875331f432
https://github.com/WebKit/WebKit/commit/a9a7da1667817922c7356d64af9d36875331f432
Author: Dan Robson <[email protected]>
Date: 2023-10-04 (Wed, 04 Oct 2023)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7616.2.9.10.5
Canonical link: https://commits.webkit.org/[email protected]
Compare: https://github.com/WebKit/WebKit/compare/fc339e342359%5E...a9a7da166781
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
