Branch: refs/heads/safari-7614.2.9.1-branch
Home: https://github.com/WebKit/WebKit
Commit: 36ed8ec6fac74f87855a13d56e6b98b37584b6e9
https://github.com/WebKit/WebKit/commit/36ed8ec6fac74f87855a13d56e6b98b37584b6e9
Author: Alan Coon <[email protected]>
Date: 2022-09-21 (Wed, 21 Sep 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.1
Canonical link: https://commits.webkit.org/[email protected]
Commit: 6f9ea5feadacd24439a4e8b7d2e65eb81ccdd776
https://github.com/WebKit/WebKit/commit/6f9ea5feadacd24439a4e8b7d2e65eb81ccdd776
Author: Alan Coon <[email protected]>
Date: 2022-09-22 (Thu, 22 Sep 2022)
Changed paths:
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/RestoreScrollPosition.mm
Log Message:
-----------
Apply patch. rdar://problem/96703879
Canonical link: https://commits.webkit.org/[email protected]
Commit: 2cc5e3e4fd01545bb0d315a7ef3bf4c1ddaa3fdf
https://github.com/WebKit/WebKit/commit/2cc5e3e4fd01545bb0d315a7ef3bf4c1ddaa3fdf
Author: Sammy Gill <[email protected]>
Date: 2022-09-22 (Thu, 22 Sep 2022)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-definite-cross-size-constrained-percentage-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-definite-cross-size-constrained-percentage-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-definite-cross-size-constrained-percentage.html
M Source/WebCore/rendering/RenderFlexibleBox.cpp
Log Message:
-----------
Cherry-pick 39cc41965e9e. rdar://problem/99469852
Consider Container Percentage Sizes When Determining Definite Cross Size
https://bugs.webkit.org/show_bug.cgi?id=245194
rdar://99469852
Reviewed by Alan Bujtas.
When computing the transferred size suggestion for the minimum size of
flex items, we need to use the intrinsic aspect ratio and the definite
cross size. Both the Flexbox specification and CSS-Sizing specification
provide information on when a size can be considered definite. This
patch implements the following portion of the Flexbox spec to determine
the definite cross size:
If a single-line flex container has a definite cross size, the outer
cross size of any stretched flex items is the flex container’s inner
cross size (clamped to the flex item’s min and max cross size) and is
considered definite.
The new test case provides an instance of a scenario where this addition
is important. The image is being used as a flex item, but the flex
container is being constrained by another containing block that has a
specified height that is smaller than the image. When computing the
automatic minimum size (specifically the transferred size suggestion),
we can determine that the flex container has a definite cross size using
its percentage specified height along with the height available to it.
Then, we can use this cross size along with the image's aspect ratio
to determine the appropriate main size.
Spec: https://www.w3.org/TR/css-flexbox-1/#min-size-auto
https://www.w3.org/TR/css-flexbox-1/#definite
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::childCrossSizeShouldUseContainerCrossSize
const):
(WebCore::RenderFlexibleBox::computeCrossSizeForChildUsingContainerCrossSize
const):
Canonical link: https://commits.webkit.org/254758@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: f5c6a889a53bcc31bdffe9653fadee198c8b357a
https://github.com/WebKit/WebKit/commit/f5c6a889a53bcc31bdffe9653fadee198c8b357a
Author: Simon Fraser <[email protected]>
Date: 2022-09-22 (Thu, 22 Sep 2022)
Changed paths:
M Source/WebCore/page/scrolling/ScrollingTree.cpp
M Source/WebCore/page/scrolling/ScrollingTree.h
M
Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.messages.in
M
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm
Log Message:
-----------
Cherry-pick e7b60434701b. rdar://problem/100283905
REGRESSION (iOS 15.5): Angular Materials style triggers poor performance on
a long scrolling page
https://bugs.webkit.org/show_bug.cgi?id=241458
<rdar://95287714>
Reviewed by Tim Horton.
Batch scrolling updates for sub-scrollers from the UI process to the web
process to avoid getting
backed up doing expensive compositing updates when the web process receives
a flood of scroll update
IPC messages.
RemoteScrollingCoordinatorProxy can use ScrollingTree's existing ability to
coalesce updates,
relying on a reply to the async IPC to know when the web process has
finished handling the previous
update.
I tried to make an API test for this, but failed; it would need to detect
when the web process
handles a stream of "did scroll" IPC messages, and would need to scroll
content that is very slow to
update. scroll events can't be used as a signal for how many scroll updates
the web process
receives.
* Source/WebCore/page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::hasPendingScrollUpdates):
* Source/WebCore/page/scrolling/ScrollingTree.h:
*
Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll):
(WebKit::RemoteScrollingCoordinatorProxy::sendScrollingTreeNodeDidScroll):
(WebKit::RemoteScrollingCoordinatorProxy::receivedLastScrollingTreeNodeDidScrollReply):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
*
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h:
*
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.messages.in:
*
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::scrollPositionChangedForNode):
Canonical link: https://commits.webkit.org/253015@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: a40cb8b4d9709ea5f4d8adf5d72a75d7fda23c62
https://github.com/WebKit/WebKit/commit/a40cb8b4d9709ea5f4d8adf5d72a75d7fda23c62
Author: Wenson Hsieh <[email protected]>
Date: 2022-09-22 (Thu, 22 Sep 2022)
Changed paths:
M Source/WebCore/html/HTMLAttachmentElement.cpp
M Source/WebCore/html/HTMLAttachmentElement.h
M Source/WebCore/html/HTMLImageElement.cpp
M Source/WebCore/html/HTMLImageElement.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm
Log Message:
-----------
Cherry-pick 47fb3d640ece. rdar://problem/98012376
[Mail Compose] Attachment goes missing after wrapping an image in a block
quote
https://bugs.webkit.org/show_bug.cgi?id=245432
rdar://98012376
Reviewed by Ryosuke Niwa.
After duplicating an existing attachment-backed image element in the DOM
using `cloneNode()` (or
similar DOM functions), `HTMLImageElement.attachmentIdentifier` returns the
old attachment
identifier of the cloned attachment rather than the identifier of the
clone. This breaks Mail's
bookkeepping around attachment data in Mail compose, and leads to the
attachment being lost upon
sending or saving a draft.
This happens because:
1. `HTMLImageElement` has an internal mechanism for keeping track of the
attachment ID of the
attachment-backed image it was cloned from, by storing the ID in
`m_pendingClonedAttachmentID` and
returning it when asked for the `attachmentIdentifier`, even if the
attachment element hasn't been
created yet. This is used to ensure that after cloning an attachment
element, removing the original,
and inserting the clone, the cloned attachment-backed image will preserve
the unique attachment ID
of the attachment-backed image it was cloned from.
2. `Document` has logic to maintain the invariant that no two attachment
elements that are connected
to it ever have the same unique identifier; to do this, we automatically
adjust the identifier of
an attachment element upon insertion into the DOM, if the ID collides with
that of an existing
attachment in the DOM.
In this bug, (2) adjusts the unique ID of the attachment underneath the
image, but the image still
has a `m_pendingClonedAttachmentID` that points to the old ID, creating an
inconsistency. To fix
this, we add a mechanism to invalidate the pending cloned attachment ID
when the ID of the
attachment under an attachment-backed image changes.
Test: WKAttachmentTests.DuplicateImageWithAttachment
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::setUniqueIdentifier):
Move the definition out of line into the implementation so that we can call
into `HTMLImageElement`.
* Source/WebCore/html/HTMLAttachmentElement.h:
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::didUpdateAttachmentIdentifier):
Clear out the `m_pendingClonedAttachmentID`.
* Source/WebCore/html/HTMLImageElement.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/254696@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: 00fea8ad1cb5c86df348d92ec141126a433fbb6b
https://github.com/WebKit/WebKit/commit/00fea8ad1cb5c86df348d92ec141126a433fbb6b
Author: Alan Coon <[email protected]>
Date: 2022-09-23 (Fri, 23 Sep 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.2
Canonical link: https://commits.webkit.org/[email protected]
Commit: 38616c13856a4aba6f2e48c6fd1365affd6de152
https://github.com/WebKit/WebKit/commit/38616c13856a4aba6f2e48c6fd1365affd6de152
Author: Alex Christensen <[email protected]>
Date: 2022-09-23 (Fri, 23 Sep 2022)
Changed paths:
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm
Log Message:
-----------
Cherry-pick 71af797599da. rdar://problem/99699584
Revert rdar://98432266
https://bugs.webkit.org/show_bug.cgi?id=245548
<rdar://99699584>
Reviewed by Per Arne Vollan.
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::initializePaths):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/254775@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: 2f26e20789d2ecb8fb4168bea59c7ed03cb1c97c
https://github.com/WebKit/WebKit/commit/2f26e20789d2ecb8fb4168bea59c7ed03cb1c97c
Author: Tyler Wilcock <[email protected]>
Date: 2022-09-23 (Fri, 23 Sep 2022)
Changed paths:
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
Log Message:
-----------
Cherry-pick ace2a410b6ff. rdar://problem/100178376
AX: AXIsolatedObject uses WeakPtr<AXIsolatedTree> in a different thread
than it was created on
https://bugs.webkit.org/show_bug.cgi?id=245437
rdar://problem/100178376
Reviewed by Andres Gonzalez.
In https://bugs.webkit.org/show_bug.cgi?id=244941, we changed
AXIsolatedObject::m_cachedTree to be a WeakPtr<AXIsolatedTree> instead
of a RefPtr<AXIsolatedTree>. This is not correct since isolated objects
are created on the main-thread, but this cached tree is necessarily used
to help service requests on the secondary thread, and WeakPtr is not
thread-safe.
To fix this, we change m_cachedTree back to a RefPtr<AXIsolatedTree>.
This requires adding some more manual clean-up in the handling of
AXIsolatedTree::m_queuedForDestruction to ensure we remove any ref-cycles
that would prevent the associated AXIsolatedTree from being destroyed.
Behavior covered by existing test,
accessibility/ax-object-destroyed-on-reload.html.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::applyPendingChanges):
Canonical link: https://commits.webkit.org/254708@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: 54e37d90cd0294d05682c4d4a4035c483df4a1b9
https://github.com/WebKit/WebKit/commit/54e37d90cd0294d05682c4d4a4035c483df4a1b9
Author: Alan Coon <[email protected]>
Date: 2022-09-26 (Mon, 26 Sep 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.3
Canonical link: https://commits.webkit.org/[email protected]
Commit: c96745b87b08061f26249efe75306d52165b13b3
https://github.com/WebKit/WebKit/commit/c96745b87b08061f26249efe75306d52165b13b3
Author: Alan Coon <[email protected]>
Date: 2022-09-26 (Mon, 26 Sep 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.4
Canonical link: https://commits.webkit.org/[email protected]
Commit: 99bff8c47b40da96f8dab35038dbeb93ac78d5c6
https://github.com/WebKit/WebKit/commit/99bff8c47b40da96f8dab35038dbeb93ac78d5c6
Author: Patrick Angle <[email protected]>
Date: 2022-09-26 (Mon, 26 Sep 2022)
Changed paths:
M Source/WebKit/UIProcess/ViewSnapshotStore.cpp
Log Message:
-----------
Cherry-pick ba43b95d6427. rdar://problem/99410517
Regression(242214) ViewSnapshotStore's snapshots are no longer volatile
https://bugs.webkit.org/show_bug.cgi?id=245490
Reviewed by Tim Horton.
Bug 242214 stopped marking view snapshots as volatile by default in order
for WebDriver to guarantee their lifetime
until it is able to convert it to base64. This causes the ViewSnapshotStore
to grow to it's limit of 400mb, instead of
being able to have snapshots disposed of sooner. The ViewSnapshotStore
should explicitly mark the snapshots it takes as
volatile to satisfy that requirement.
* Source/WebKit/UIProcess/ViewSnapshotStore.cpp:
(WebKit::ViewSnapshotStore::recordSnapshot):
Canonical link: https://commits.webkit.org/254734@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: 6bbc013dd57e31bd875bd803348160b1970b5428
https://github.com/WebKit/WebKit/commit/6bbc013dd57e31bd875bd803348160b1970b5428
Author: Jer Noble <[email protected]>
Date: 2022-09-27 (Tue, 27 Sep 2022)
Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
Log Message:
-----------
Cherry-pick 249fdd9c0f8b. rdar://problem/100199996
Hulu.com content is stretched when moving to next episode
https://bugs.webkit.org/show_bug.cgi?id=245641
<rdar://100199996>
Reviewed by Eric Carlson.
As a prelude: at some point, WebKit fixed a bug where the `object-fit` CSS
property was not honored
if set before media began loading in a HTMLVideoElement. Hulu.com sets it's
video element's
`object-fit:` style to `fill`. When Hulu.com navigates to the next episode
in a playlist, it resets
the <video>'s `width:` and `height:` style to 100%, causing the video to
stretch visibly. Previous
to the mentioned fix, this bug would "hide" this behavior, by causing the
renderer to ignore `fill`
and default to `contain`.
Add a quirk for Hulu.com that reverts to the previous (broken) behavior.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateMediaPlayer):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsVideoShouldMaintainAspectRatioQuirk const):
* Source/WebCore/page/Quirks.h:
Canonical link: https://commits.webkit.org/254848@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: e572c94ed0a174c4812796aec9f9aecba40aaaf3
https://github.com/WebKit/WebKit/commit/e572c94ed0a174c4812796aec9f9aecba40aaaf3
Author: Tyler Wilcock <[email protected]>
Date: 2022-09-27 (Tue, 27 Sep 2022)
Changed paths:
M LayoutTests/accessibility-isolated-tree/TestExpectations
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
Log Message:
-----------
Cherry-pick 523acc306f2b. rdar://problem/100245048
AX: AXIsolatedTree::updateChildren doesn't propagate updates downwards when
AccessibilityObject::m_subtreeDirty is true
https://bugs.webkit.org/show_bug.cgi?id=245694
rdar://100245048
Reviewed by Chris Fleizach.
When AXIsolatedTree::updateChildren updates the children of the nearest
in-isolated-tree
ancestor to the parameter object, it compares the new children of that
object to the "old"
ones, i.e. the children for that object in the nodemap. If we found that
the object's new children
included an object that already existed in the old nodemap children, we do
nothing (besides
deliberately not queuing it for deletion).
Based on the update pattern of some sites, doing nothing in this scenario
is not right, since this
existing object could have m_subtreeDirty set, meaning we need to propagate
descendant updates downwards.
This is exactly what the live tree does in AccessibilityObject::insertChild.
With this patch, we detect m_subtreeDirty in this scenario and propagate
that update downwards with
AXIsolatedTree::collectNodeChangesForSubtree.
Fixes accessibility/text-alternative-calculation-from-listbox.html which is
dependent on m_subtreeDirty
updates being handled properly.
* LayoutTests/accessibility-isolated-tree/TestExpectations:
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::hasDirtySubtree const): Added.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateChildren):
Canonical link: https://commits.webkit.org/254899@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: de05773fb577b050bf71fdb49eda00566e23183f
https://github.com/WebKit/WebKit/commit/de05773fb577b050bf71fdb49eda00566e23183f
Author: Alan Coon <[email protected]>
Date: 2022-09-28 (Wed, 28 Sep 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.5
Canonical link: https://commits.webkit.org/[email protected]
Commit: 937cda6f64651116b400649c5d7957085d8017f4
https://github.com/WebKit/WebKit/commit/937cda6f64651116b400649c5d7957085d8017f4
Author: Alan Coon <[email protected]>
Date: 2022-09-29 (Thu, 29 Sep 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.6
Canonical link: https://commits.webkit.org/[email protected]
Commit: 19f568bef254f61accfef7e15355f00f3801b785
https://github.com/WebKit/WebKit/commit/19f568bef254f61accfef7e15355f00f3801b785
Author: Youenn Fablet <[email protected]>
Date: 2022-09-29 (Thu, 29 Sep 2022)
Changed paths:
A
LayoutTests/http/wpt/service-workers/fetch-service-worker-navigation-preload.https-expected.txt
A
LayoutTests/http/wpt/service-workers/fetch-service-worker-navigation-preload.https.html
M
LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-worker.js
M
LayoutTests/http/wpt/service-workers/resources/fetch-service-worker-preload-script.py
M Source/WebCore/Modules/fetch/FetchResponse.cpp
M Source/WebCore/Modules/fetch/FetchResponse.h
M Source/WebCore/workers/service/FetchEvent.cpp
M Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp
M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp
Log Message:
-----------
Cherry-pick 757903c6fe5a. rdar://problem/98144044
FetchEvent should not start its navigation preload response load if the
preload was already used
https://bugs.webkit.org/show_bug.cgi?id=245788
rdar://98144044
Reviewed by Alex Christensen.
Creating the navigation preload promise was scheduling a load which is
hitting the network if the preload is no longer in network process.
This case happens if the navigation preload promise is actually used in
respondWith.
To circumvent this issue, we do not trigger the load if the preload is used
in respondWith.
Add logs to capture the fact that a load is not getting its expected
preload.
Drive-by fixes to actually use the current preload request and not the
loader original request.
This might change in case of redirections.
Covered by newly added test which mirrors what we were testing for
non-exposed navigation preloads.
*
LayoutTests/http/wpt/service-workers/fetch-service-worker-navigation-preload.https-expected.txt:
Added.
*
LayoutTests/http/wpt/service-workers/fetch-service-worker-navigation-preload.https.html:
Added.
*
LayoutTests/http/wpt/service-workers/fetch-service-worker-preload-worker.js:
(event.event.request.url.includes):
*
LayoutTests/http/wpt/service-workers/resources/fetch-service-worker-preload-script.py:
(main):
* Source/WebCore/Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::markAsUsedForPreload):
(WebCore::FetchResponse::markAsDisturbed): Deleted.
* Source/WebCore/Modules/fetch/FetchResponse.h:
* Source/WebCore/workers/service/FetchEvent.cpp:
(WebCore::FetchEvent::navigationPreloadIsReady):
* Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::processResponse):
* Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::fromNavigationPreloader):
(WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::loadBodyFromPreloader):
Canonical link: https://commits.webkit.org/254992@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: 9eb26c3957689a631ba21a3a309ed03f965fcd16
https://github.com/WebKit/WebKit/commit/9eb26c3957689a631ba21a3a309ed03f965fcd16
Author: Alan Coon <[email protected]>
Date: 2022-09-30 (Fri, 30 Sep 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.7
Canonical link: https://commits.webkit.org/[email protected]
Commit: 13d0168216d937ad7f1d813d7457e5af58cc840a
https://github.com/WebKit/WebKit/commit/13d0168216d937ad7f1d813d7457e5af58cc840a
Author: Chris Dumez <[email protected]>
Date: 2022-09-30 (Fri, 30 Sep 2022)
Changed paths:
A LayoutTests/fast/history/history-replace-updates-current-item-expected.txt
A LayoutTests/fast/history/history-replace-updates-current-item.html
A
LayoutTests/fast/history/resources/history-replace-updates-current-item-done.html
A
LayoutTests/fast/history/resources/history-replace-updates-current-item-goback.html
M LayoutTests/fast/loader/stateobjects/pushstate-frequency-iframe.html
M LayoutTests/fast/loader/stateobjects/pushstate-frequency.html
M
LayoutTests/fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-expected.txt
M
LayoutTests/fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html
M LayoutTests/fast/loader/stateobjects/replacestate-frequency-iframe.html
M LayoutTests/fast/loader/stateobjects/replacestate-frequency.html
M LayoutTests/fast/loader/stateobjects/resources/pushstate-iframe.html
M LayoutTests/fast/loader/stateobjects/resources/replacestate-iframe.html
M LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited.html
R
LayoutTests/http/tests/history/history-replace-updates-current-item-expected.txt
R LayoutTests/http/tests/history/history-replace-updates-current-item.html
R
LayoutTests/http/tests/history/resources/history-replace-updates-current-item-done.html
R
LayoutTests/http/tests/history/resources/history-replace-updates-current-item-goback.html
M LayoutTests/loader/stateobjects/pushstate-size-iframe.html
M LayoutTests/loader/stateobjects/pushstate-size.html
M LayoutTests/loader/stateobjects/replacestate-size-iframe.html
M LayoutTests/loader/stateobjects/replacestate-size.html
M LayoutTests/loader/stateobjects/resources/pushstate-iframe.html
M LayoutTests/loader/stateobjects/resources/replacestate-iframe.html
M LayoutTests/platform/wk2/TestExpectations
M LayoutTests/swipe/pushState-cached-back-swipe.html
M LayoutTests/swipe/pushState-programmatic-back-while-swiping-crash.html
M Source/WebCore/page/History.cpp
M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
M Source/WebKit/UIProcess/ProvisionalPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
M
Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp
M
Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp
Log Message:
-----------
Cherry-pick 7e840610aa3a. rdar://problem/100225581
Revert [254005@main] Validate item URL in BackForwardAddItem() IPC
https://bugs.webkit.org/show_bug.cgi?id=244620
<rdar://100225581>
Unreviewed, revert 254005@main since it because the MySubaru app to hang on
launch.
*
LayoutTests/fast/history/history-replace-updates-current-item-expected.txt:
Added.
* LayoutTests/fast/history/history-replace-updates-current-item.html:
Renamed from
LayoutTests/http/tests/history/history-replace-updates-current-item.html.
*
LayoutTests/fast/history/resources/history-replace-updates-current-item-done.html:
Renamed from
LayoutTests/http/tests/history/resources/history-replace-updates-current-item-done.html.
*
LayoutTests/fast/history/resources/history-replace-updates-current-item-goback.html:
Renamed from
LayoutTests/http/tests/history/resources/history-replace-updates-current-item-goback.html.
* LayoutTests/fast/loader/stateobjects/pushstate-frequency-iframe.html:
* LayoutTests/fast/loader/stateobjects/pushstate-frequency.html:
*
LayoutTests/fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-expected.txt:
*
LayoutTests/fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
* LayoutTests/fast/loader/stateobjects/replacestate-frequency-iframe.html:
* LayoutTests/fast/loader/stateobjects/replacestate-frequency.html:
* LayoutTests/fast/loader/stateobjects/resources/pushstate-iframe.html:
* LayoutTests/fast/loader/stateobjects/resources/replacestate-iframe.html:
* LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited.html:
*
LayoutTests/http/tests/history/history-replace-updates-current-item-expected.txt:
Removed.
* LayoutTests/loader/stateobjects/pushstate-size-iframe.html:
* LayoutTests/loader/stateobjects/pushstate-size.html:
* LayoutTests/loader/stateobjects/replacestate-size-iframe.html:
* LayoutTests/loader/stateobjects/replacestate-size.html:
* LayoutTests/loader/stateobjects/resources/pushstate-iframe.html:
* LayoutTests/loader/stateobjects/resources/replacestate-iframe.html:
* LayoutTests/platform/wk2/TestExpectations:
* LayoutTests/swipe/pushState-cached-back-swipe.html:
* LayoutTests/swipe/pushState-programmatic-back-while-swiping-crash.html:
* Source/WebCore/page/History.cpp:
(WebCore::History::stateObjectAdded):
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::didReceiveMessage):
(WebKit::ProvisionalPageProxy::backForwardAddItem): Deleted.
* Source/WebKit/UIProcess/ProvisionalPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsyncShared):
(WebKit::WebPageProxy::backForwardAddItem):
(WebKit::WebPageProxy::backForwardAddItemShared): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::setIsInProcessCache):
(WebKit::WebProcessProxy::addPreviouslyApprovedFileURL): Deleted.
(WebKit::WebProcessProxy::wasPreviouslyApprovedFileURL const): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
*
Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:
(TestWebKitAPI::didCommitNavigationCallback):
*
Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp:
(TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::willSendRequestForFrame):
Canonical link: https://commits.webkit.org/255005@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: c9a51d0647c7713f6d6ce27f06d0cedbc6dd1f02
https://github.com/WebKit/WebKit/commit/c9a51d0647c7713f6d6ce27f06d0cedbc6dd1f02
Author: Alan Coon <[email protected]>
Date: 2022-10-03 (Mon, 03 Oct 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.8
Canonical link: https://commits.webkit.org/[email protected]
Commit: 9d23a1aa42983fc91202cc0674b084166df2659f
https://github.com/WebKit/WebKit/commit/9d23a1aa42983fc91202cc0674b084166df2659f
Author: Alan Coon <[email protected]>
Date: 2022-10-05 (Wed, 05 Oct 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.9
Canonical link: https://commits.webkit.org/[email protected]
Commit: 6add257830a77e8fe055a29c590ed87e82a81c69
https://github.com/WebKit/WebKit/commit/6add257830a77e8fe055a29c590ed87e82a81c69
Author: Russell Epstein <[email protected]>
Date: 2022-10-07 (Fri, 07 Oct 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.10
Canonical link: https://commits.webkit.org/[email protected]
Commit: 206f33adf1e2d2257f48f6059260138fcaf7f027
https://github.com/WebKit/WebKit/commit/206f33adf1e2d2257f48f6059260138fcaf7f027
Author: Tyler Wilcock <[email protected]>
Date: 2022-10-07 (Fri, 07 Oct 2022)
Changed paths:
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
Log Message:
-----------
Cherry-pick 8089baaa58f2. rdar://problem/100855009
AX: VoiceOver double reads list markers, doesn't output braille for list
items
https://bugs.webkit.org/show_bug.cgi?id=246188
rdar://100855009
Reviewed by Chris Fleizach.
This is a regression from:
https://github.com/WebKit/WebKit/commit/3395d79137499cc61964d7e5abd34031bc4977cc
(AX: Expose suggestion, insertion, deletion roles and attributes)
That commit allowed static text elements to return attributed strings.
Due to some quirks in VoiceOver (and also a different bug in
WebKit), this causes issues that will need to be addressed at a later time.
This patch effectively reverts the Mac portion of that commit by
removing the code that allowed AccessibilityRole::StaticText elements
to return attributed strings.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::text const):
Stop allowing isStaticText() elements to return textUnderElement.
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper
accessibilityAttributeValue:forParameter:]):
Stop allowing isStaticText() elements to doAXAttributedStringForRange.
Canonical link: https://commits.webkit.org/255276@main
Canonical link: https://commits.webkit.org/[email protected]
Commit: adf794630494c0992a6b29bbd9121c9e9923d58b
https://github.com/WebKit/WebKit/commit/adf794630494c0992a6b29bbd9121c9e9923d58b
Author: Alan Coon <[email protected]>
Date: 2022-10-14 (Fri, 14 Oct 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.11
Canonical link: https://commits.webkit.org/[email protected]
Commit: 92f1d956cb370e89e28243004272f5f172231ee9
https://github.com/WebKit/WebKit/commit/92f1d956cb370e89e28243004272f5f172231ee9
Author: Russell Epstein <[email protected]>
Date: 2022-10-17 (Mon, 17 Oct 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.12
Canonical link: https://commits.webkit.org/[email protected]
Commit: 385cb63251610f3e739a9c181c0dd7100223f03a
https://github.com/WebKit/WebKit/commit/385cb63251610f3e739a9c181c0dd7100223f03a
Author: Russell Epstein <[email protected]>
Date: 2022-10-17 (Mon, 17 Oct 2022)
Changed paths:
M Source/WebCore/rendering/RenderImage.cpp
Log Message:
-----------
Apply patch. rdar://problem/101205947
Canonical link: https://commits.webkit.org/[email protected]
Commit: 894737efd4d9a4e1bc14a71b60d93030e89e288b
https://github.com/WebKit/WebKit/commit/894737efd4d9a4e1bc14a71b60d93030e89e288b
Author: Alan Coon <[email protected]>
Date: 2022-10-20 (Thu, 20 Oct 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.2.9.1.13
Canonical link: https://commits.webkit.org/[email protected]
Compare: https://github.com/WebKit/WebKit/compare/36ed8ec6fac7%5E...894737efd4d9
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
