Branch: refs/heads/safari-7614.4.1.1-branch
Home: https://github.com/WebKit/WebKit
Commit: 586549fa38506d779d3d3e2711d5e2c62bcec177
https://github.com/WebKit/WebKit/commit/586549fa38506d779d3d3e2711d5e2c62bcec177
Author: Alan Coon <[email protected]>
Date: 2022-12-13 (Tue, 13 Dec 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.4.1.1.1
Canonical link: https://commits.webkit.org/[email protected]
Commit: 07bb3e34481412627ad63127a3bf4e1a77f704b2
https://github.com/WebKit/WebKit/commit/07bb3e34481412627ad63127a3bf4e1a77f704b2
Author: Alan Coon <[email protected]>
Date: 2022-12-13 (Tue, 13 Dec 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.4.1.1.2
Canonical link: https://commits.webkit.org/[email protected]
Commit: 15e2109c6d373dff5be91c02c29904f3377b6ab2
https://github.com/WebKit/WebKit/commit/15e2109c6d373dff5be91c02c29904f3377b6ab2
Author: Alan Coon <[email protected]>
Date: 2022-12-20 (Tue, 20 Dec 2022)
Changed paths:
M Source/JavaScriptCore/Configurations/Version.xcconfig
M Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
M Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
M Source/WebCore/Configurations/Version.xcconfig
M Source/WebCore/PAL/Configurations/Version.xcconfig
M Source/WebGPU/Configurations/Version.xcconfig
M Source/WebInspectorUI/Configurations/Version.xcconfig
M Source/WebKit/Configurations/Version.xcconfig
M Source/WebKitLegacy/mac/Configurations/Version.xcconfig
Log Message:
-----------
Versioning.
WebKit-7614.4.1.1.3
Canonical link: https://commits.webkit.org/[email protected]
Commit: 25e18a645ed01c79d047652a94609736ff0dfb2b
https://github.com/WebKit/WebKit/commit/25e18a645ed01c79d047652a94609736ff0dfb2b
Author: Wenson Hsieh <[email protected]>
Date: 2022-12-20 (Tue, 20 Dec 2022)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm
Log Message:
-----------
Cherry-pick 492490a51a6c. rdar://problem/102360839
Mitigate crashes when removing KVO from NSWindow in
-[WKWindowVisibilityObserver stopObserving:]
https://bugs.webkit.org/show_bug.cgi?id=249103
rdar://102360839
Reviewed by Patrick Angle.
After the fix in 256334@main, Music sometimes crashes when destroying
`NSWindow`, when
`WKWindowVisibilityObserver` attempts to remove key-value observers for
"contentLayoutRect" and
"titlebarAppearsTransparent" from the window that were not added in the
first place.
While I haven't been able to reproduce the crash locally or come up with a
test case that (exactly)
replicates the crashing stack during `NSWindow` destruction, it should be
possible to avoid it
altogether by guarding KVO registration and unregistration by using an
associated object on the
`NSWindow` to indicate when `WKWindowVisibilityObserver` has key-value
observers to the window. If
this flag is not set, then we avoid attempting to unregister KVO;
similarly, if this flag is set,
then we avoid attempting to re-register KVO.
Test:
WKWebView.PrepareForMoveToWindowShouldNotCrashWhenRemovingWindowObservers
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(-[WKWindowVisibilityObserver startObserving:]):
(-[WKWindowVisibilityObserver stopObserving:]):
Use the `_impl` pointer as the context key.
(WebKit::WebViewImpl::viewWillMoveToWindowImpl):
(WebKit::WebViewImpl::viewWillMoveToWindow):
Move a debug assertion from `viewWillMoveToWindowImpl` into the call site
in `viewWillMoveToWindow`,
such that the assertion doesn't fire due to the SPI being misused by a
client (which the new test
case exercises).
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
Add a (somewhat contrived) API test that exercises the mitigation.
Canonical link: https://commits.webkit.org/257860@main
Canonical link: https://commits.webkit.org/[email protected]
Compare: https://github.com/WebKit/WebKit/compare/586549fa3850%5E...25e18a645ed0
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
