Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7659f4a59ccae8d9c19f6f7e18f0e08536dbc99
      
https://github.com/WebKit/WebKit/commit/c7659f4a59ccae8d9c19f6f7e18f0e08536dbc99
  Author: Tadeu Zagallo <[email protected]>
  Date:   2023-10-30 (Mon, 30 Oct 2023)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp

  Log Message:
  -----------
  [WebGPU] Opening https://www.babylonjs.com/demos/webgpu/forestwebgpu results 
in a compilation error
https://bugs.webkit.org/show_bug.cgi?id=263690
rdar://117501463

Reviewed by Mike Wyrzykowski.

When generating argument buffers from bind groups, I added a short circuit to 
skip
generating structs and parameters for empty bind groups, but I forgot to 
increment
the bind group id if the group was empty. This caused groups that come after an
empty bind group to have wrong id, which resulted in the compilation error.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertStructs):

Canonical link: https://commits.webkit.org/269930@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to