Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b7a48dcd4cf2d35900aabad9d1a0aeb5d94415e2
https://github.com/WebKit/WebKit/commit/b7a48dcd4cf2d35900aabad9d1a0aeb5d94415e2
Author: Charlie Wolfe <[email protected]>
Date: 2023-10-30 (Mon, 30 Oct 2023)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Log Message:
-----------
Refactor some drag handling IPC to use sendWithAsyncReply()
https://bugs.webkit.org/show_bug.cgi?id=263861
rdar://117665237
Reviewed by Wenson Hsieh.
Drag actions currently send a separate IPC call to notify the UI process that
they have been handled.
This patch makes changes to use completion handlers instead. This will make it
easier to implement drag
events for site isolation and matches how mouse/key/touch events are handled.
Also some clean up to remove unused function parameters and to only send
sandbox extensions for the IPC
calls which require them.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDragOperation):
(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::dragEnded):
(WebKit::WebPageProxy::didPerformDragOperation): Deleted.
(WebKit::WebPageProxy::didEndDragging): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::draggingExited):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dropInteraction:sessionDidExit:]):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::performDragOperation):
(WebKit::WebPage::dragEnded):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
Canonical link: https://commits.webkit.org/269965@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
