Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f1664d74b5e35d8965b5c2767b1c32a1511dd3f6
https://github.com/WebKit/WebKit/commit/f1664d74b5e35d8965b5c2767b1c32a1511dd3f6
Author: Alan Baradlay <[email protected]>
Date: 2023-11-01 (Wed, 01 Nov 2023)
Changed paths:
A
LayoutTests/fast/block/right-to-left-out-of-flow-with-inflow-content-expected.html
A LayoutTests/fast/block/right-to-left-out-of-flow-with-inflow-content.html
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
Log Message:
-----------
REGRESSION(267944@main): wpt /css/CSS2/positioning/abspos-block-level-001.html
https://bugs.webkit.org/show_bug.cgi?id=263892
Reviewed by Antti Koivisto.
This patch extends the logic of "is there an inflow content before this out of
flow box" by
taking inline direction into account.
We already handle bidi (logical position vs. visual position) just fine but
there's another layer of visual order here.
When the content is RTL (again not to be confused with bidi) the logic of
finding out if an out of flow box
has preceding in flow content needs to start from the (visual) right edge and
follow the inline direction.
(i.e. in addition to resolving the logical -> visual order, we also need to
travers these run lists in inline direction order)
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
(WebCore::Layout::setGeometryForOutOfFlowBoxes):
(WebCore::Layout::InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes):
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
(WebCore::Layout::InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes):
Canonical link: https://commits.webkit.org/270069@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
