Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e32ef8fc4f44723e714e58ab2b7f4bdac61421f0
https://github.com/WebKit/WebKit/commit/e32ef8fc4f44723e714e58ab2b7f4bdac61421f0
Author: Alex Christensen <[email protected]>
Date: 2023-11-03 (Fri, 03 Nov 2023)
Changed paths:
M Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp
M Source/WebCore/page/scrolling/ScrollingStateFixedNode.h
M Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.cpp
M Source/WebCore/page/scrolling/ScrollingStateNode.cpp
M Source/WebCore/page/scrolling/ScrollingStateNode.h
M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.cpp
M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.h
M Source/WebCore/page/scrolling/ScrollingStatePositionedNode.cpp
M Source/WebCore/page/scrolling/ScrollingStatePositionedNode.h
M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp
M Source/WebCore/page/scrolling/ScrollingStateStickyNode.cpp
M Source/WebCore/page/scrolling/ScrollingStateStickyNode.h
M
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp
M
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h
M
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in
Log Message:
-----------
Finish generating serialization of ScrollingStateNode subclasses
https://bugs.webkit.org/show_bug.cgi?id=264137
rdar://117890830
Reviewed by Brady Eidson.
In order for the OptionalTuple bits to line up in a way that the IPC testing
API expects,
we need to reuse the second and third bits for the members of subclasses. I
manually verified
that all uses of these values is only in the context of having verified that
the node is
of the correct subclass, so the bit name collision should have no effect. I
added some comments
to make it more clear that this is happening for future bit users.
* Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode):
(WebCore::ScrollingStateFixedNode::create): Deleted.
* Source/WebCore/page/scrolling/ScrollingStateFixedNode.h:
* Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.cpp:
(WebCore::ScrollingStateFrameHostingNode::ScrollingStateFrameHostingNode):
* Source/WebCore/page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode):
* Source/WebCore/page/scrolling/ScrollingStateNode.h:
* Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.cpp:
(WebCore::ScrollingStateOverflowScrollProxyNode::ScrollingStateOverflowScrollProxyNode):
(WebCore::ScrollingStateOverflowScrollProxyNode::create): Deleted.
* Source/WebCore/page/scrolling/ScrollingStateOverflowScrollProxyNode.h:
(WebCore::ScrollingStateOverflowScrollProxyNode::create):
* Source/WebCore/page/scrolling/ScrollingStatePositionedNode.cpp:
(WebCore::ScrollingStatePositionedNode::ScrollingStatePositionedNode):
(WebCore::ScrollingStatePositionedNode::create): Deleted.
* Source/WebCore/page/scrolling/ScrollingStatePositionedNode.h:
* Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
* Source/WebCore/page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):
(WebCore::ScrollingStateStickyNode::create): Deleted.
* Source/WebCore/page/scrolling/ScrollingStateStickyNode.h:
*
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(encodeNodeShared): Deleted.
(decodeNodeShared): Deleted.
(ArgumentCoder<WebCore::ScrollingStateOverflowScrollProxyNode>::encode):
Deleted.
(ArgumentCoder<WebCore::ScrollingStateOverflowScrollProxyNode>::decode):
Deleted.
(ArgumentCoder<WebCore::ScrollingStateFixedNode>::encode): Deleted.
(ArgumentCoder<WebCore::ScrollingStateFixedNode>::decode): Deleted.
(ArgumentCoder<WebCore::ScrollingStateStickyNode>::encode): Deleted.
(ArgumentCoder<WebCore::ScrollingStateStickyNode>::decode): Deleted.
(ArgumentCoder<WebCore::ScrollingStatePositionedNode>::encode): Deleted.
(ArgumentCoder<WebCore::ScrollingStatePositionedNode>::decode): Deleted.
* Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h:
*
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in:
Canonical link: https://commits.webkit.org/270218@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
