Title: [109836] trunk
- Revision
- 109836
- Author
- [email protected]
- Date
- 2012-03-05 19:07:53 -0800 (Mon, 05 Mar 2012)
Log Message
Source/WebCore: [Forms] HTMLFieldSetForms.idl doesn't have name attribute.
https://bugs.webkit.org/show_bug.cgi?id=80108
Patch by Yoshifumi Inoue <[email protected]> on 2012-03-05
Reviewed by Hajime Morita.
Test: fast/forms/fieldset/fieldset-name.html
* html/HTMLFieldSetElement.idl: Add "name" attribute.
LayoutTests: [Forms] HTMLFieldSetForms.idl doesn't have name attribute.
https://bugs.webkit.org/show_bug.cgi?id=81008
Test read/write attribute "name" of fieldset element.
Patch by Yoshifumi Inoue <[email protected]> on 2012-03-05
Reviewed by Hajime Morita.
* fast/forms/fieldset/fieldset-name-expected.txt: Added.
* fast/forms/fieldset/fieldset-name.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (109835 => 109836)
--- trunk/LayoutTests/ChangeLog 2012-03-06 02:42:55 UTC (rev 109835)
+++ trunk/LayoutTests/ChangeLog 2012-03-06 03:07:53 UTC (rev 109836)
@@ -1,3 +1,15 @@
+2012-03-05 Yoshifumi Inoue <[email protected]>
+
+ [Forms] HTMLFieldSetForms.idl doesn't have name attribute.
+ https://bugs.webkit.org/show_bug.cgi?id=81008
+
+ Test read/write attribute "name" of fieldset element.
+
+ Reviewed by Hajime Morita.
+
+ * fast/forms/fieldset/fieldset-name-expected.txt: Added.
+ * fast/forms/fieldset/fieldset-name.html: Added.
+
2012-03-05 Tony Chang <[email protected]>
add tests for multiline flexbox and flex-pack
Added: trunk/LayoutTests/fast/forms/fieldset/fieldset-name-expected.txt (0 => 109836)
--- trunk/LayoutTests/fast/forms/fieldset/fieldset-name-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/fieldset/fieldset-name-expected.txt 2012-03-06 03:07:53 UTC (rev 109836)
@@ -0,0 +1,26 @@
+This test checks fieldset.name attribute.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Read from HTML
+PASS fs1.name is "a"
+PASS fs1.getAttribute("name") is "a"
+fs1.name="b"
+PASS fs1.name is "b"
+PASS fs1.getAttribute("name") is "b"
+fs1.name=1234
+PASS fs1.name is "1234"
+PASS fs1.getAttribute("name") is "1234"
+fs1.name=null
+PASS fs1.name is ""
+PASS fs1.getAttribute("name") is null
+PASS fs1.hasAttribute("name") is false
+fs1.name=undefined
+PASS fs1.name is "undefined"
+PASS fs1.getAttribute("name") is "undefined"
+PASS fs1.hasAttribute("name") is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/forms/fieldset/fieldset-name.html (0 => 109836)
--- trunk/LayoutTests/fast/forms/fieldset/fieldset-name.html (rev 0)
+++ trunk/LayoutTests/fast/forms/fieldset/fieldset-name.html 2012-03-06 03:07:53 UTC (rev 109836)
@@ -0,0 +1,34 @@
+<script src=""
+<fieldset id="fs1" name="a"></fieldset>
+<script>
+description("This test checks fieldset.name attribute.");
+debug("Read from HTML");
+shouldBe('fs1.name', '"a"');
+shouldBe('fs1.getAttribute("name")', '"a"');
+
+debug('fs1.name="b"');
+fs1.name = "b";
+shouldBe('fs1.name', '"b"');
+shouldBe('fs1.getAttribute("name")', '"b"');
+
+debug('fs1.name=1234');
+fs1.name = 1234;
+shouldBe('fs1.name', '"1234"');
+shouldBe('fs1.getAttribute("name")', '"1234"');
+
+// FIXME: The specification doesn't have clear description for setting null to name.
+// We may need to update below once the specification fixed.
+debug('fs1.name=null');
+fs1.name = null;
+shouldBe('fs1.name', '""');
+shouldBeNull('fs1.getAttribute("name")');
+shouldBeFalse('fs1.hasAttribute("name")');
+
+debug('fs1.name=undefined');
+fs1.name = undefined;
+shouldBe('fs1.name', '"undefined"');
+shouldBe('fs1.getAttribute("name")', '"undefined"');
+shouldBeTrue('fs1.hasAttribute("name")');
+</script>
+<script src=""
+
Modified: trunk/Source/WebCore/ChangeLog (109835 => 109836)
--- trunk/Source/WebCore/ChangeLog 2012-03-06 02:42:55 UTC (rev 109835)
+++ trunk/Source/WebCore/ChangeLog 2012-03-06 03:07:53 UTC (rev 109836)
@@ -1,3 +1,14 @@
+2012-03-05 Yoshifumi Inoue <[email protected]>
+
+ [Forms] HTMLFieldSetForms.idl doesn't have name attribute.
+ https://bugs.webkit.org/show_bug.cgi?id=80108
+
+ Reviewed by Hajime Morita.
+
+ Test: fast/forms/fieldset/fieldset-name.html
+
+ * html/HTMLFieldSetElement.idl: Add "name" attribute.
+
2012-03-05 Levi Weintraub <[email protected]>
Update usage of LayoutUnits in RenderBox
Modified: trunk/Source/WebCore/html/HTMLFieldSetElement.idl (109835 => 109836)
--- trunk/Source/WebCore/html/HTMLFieldSetElement.idl 2012-03-06 02:42:55 UTC (rev 109835)
+++ trunk/Source/WebCore/html/HTMLFieldSetElement.idl 2012-03-06 03:07:53 UTC (rev 109836)
@@ -21,6 +21,7 @@
interface HTMLFieldSetElement : HTMLElement {
readonly attribute HTMLFormElement form;
+ attribute [Reflect] DOMString name;
readonly attribute boolean willValidate;
readonly attribute ValidityState validity;
readonly attribute DOMString validationMessage;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
