Title: [109841] trunk/Source/WebCore
Revision
109841
Author
[email protected]
Date
2012-03-05 20:24:41 -0800 (Mon, 05 Mar 2012)

Log Message

GraphicsContext3D.h should include RefCounted.h explicitly
https://bugs.webkit.org/show_bug.cgi?id=80251

Reviewed by Rob Buis.

GraphicsContext3D.h was using RefCounted but including RefCounted.h indirectly
through GraphicsLayer.h through Animation.h. However Animation.h is included
by GraphicsLayer.h only when ACCELERATED_COMPOSITING is on. For some configurations
that don't use ACCELERATED_COMPOSITING but use GraphicsContext3D, like the
BlackBerry x86 configuration, the indirect inclusion will fail.

This patch is adding explicit inclusion of RefCounted.h to avoid that kind of
problem.

* platform/graphics/GraphicsContext3D.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (109840 => 109841)


--- trunk/Source/WebCore/ChangeLog	2012-03-06 04:20:47 UTC (rev 109840)
+++ trunk/Source/WebCore/ChangeLog	2012-03-06 04:24:41 UTC (rev 109841)
@@ -1,3 +1,21 @@
+2012-03-05  Leo Yang  <[email protected]>
+
+        GraphicsContext3D.h should include RefCounted.h explicitly
+        https://bugs.webkit.org/show_bug.cgi?id=80251
+
+        Reviewed by Rob Buis.
+
+        GraphicsContext3D.h was using RefCounted but including RefCounted.h indirectly
+        through GraphicsLayer.h through Animation.h. However Animation.h is included
+        by GraphicsLayer.h only when ACCELERATED_COMPOSITING is on. For some configurations
+        that don't use ACCELERATED_COMPOSITING but use GraphicsContext3D, like the
+        BlackBerry x86 configuration, the indirect inclusion will fail.
+
+        This patch is adding explicit inclusion of RefCounted.h to avoid that kind of
+        problem.
+
+        * platform/graphics/GraphicsContext3D.h:
+
 2012-03-05  Kenichi Ishibashi  <[email protected]>
 
         [WebSocket] Should raise SYNTAX_ERR when message contains unpaired surrogates

Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h (109840 => 109841)


--- trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h	2012-03-06 04:20:47 UTC (rev 109840)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h	2012-03-06 04:24:41 UTC (rev 109841)
@@ -33,6 +33,7 @@
 #include <wtf/HashMap.h>
 #include <wtf/ListHashSet.h>
 #include <wtf/Noncopyable.h>
+#include <wtf/RefCounted.h>
 
 // FIXME: Find a better way to avoid the name confliction for NO_ERROR.
 #if ((PLATFORM(CHROMIUM) && OS(WINDOWS)) || PLATFORM(WIN) || (PLATFORM(QT) && OS(WINDOWS)))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to