Title: [109870] trunk/Source/WebCore
Revision
109870
Author
[email protected]
Date
2012-03-05 23:59:24 -0800 (Mon, 05 Mar 2012)

Log Message

WebAudio JSC-related fixes
https://bugs.webkit.org/show_bug.cgi?id=80299

Reviewed by Adam Barth.

* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContextConstructor::constructJSAudioContext):
Wrap the audio context in a DOM wrapper.
* webaudio/AudioContext.idl: No need to protect EventTarget by V8
guards, I think.
* webaudio/_javascript_AudioNode.idl: Ditto.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (109869 => 109870)


--- trunk/Source/WebCore/ChangeLog	2012-03-06 07:40:46 UTC (rev 109869)
+++ trunk/Source/WebCore/ChangeLog	2012-03-06 07:59:24 UTC (rev 109870)
@@ -1,3 +1,17 @@
+2012-03-05  Philippe Normand  <[email protected]>
+
+        WebAudio JSC-related fixes
+        https://bugs.webkit.org/show_bug.cgi?id=80299
+
+        Reviewed by Adam Barth.
+
+        * bindings/js/JSAudioContextCustom.cpp:
+        (WebCore::JSAudioContextConstructor::constructJSAudioContext):
+        Wrap the audio context in a DOM wrapper.
+        * webaudio/AudioContext.idl: No need to protect EventTarget by V8
+        guards, I think.
+        * webaudio/_javascript_AudioNode.idl: Ditto.
+
 2012-03-05  Kishore Bolisetty  <[email protected]>
 
         Element not fully repainted after application and removal of transform

Modified: trunk/Source/WebCore/bindings/js/JSAudioContextCustom.cpp (109869 => 109870)


--- trunk/Source/WebCore/bindings/js/JSAudioContextCustom.cpp	2012-03-06 07:40:46 UTC (rev 109869)
+++ trunk/Source/WebCore/bindings/js/JSAudioContextCustom.cpp	2012-03-06 07:59:24 UTC (rev 109870)
@@ -101,7 +101,7 @@
     if (!audioContext.get())
         return throwVMError(exec, createReferenceError(exec, "Error creating AudioContext"));
 
-    return JSValue::encode(asObject(toJS(exec, jsConstructor->globalObject(), audioContext.get())));
+    return JSValue::encode(CREATE_DOM_WRAPPER(exec, jsConstructor->globalObject(), AudioContext, audioContext.get()));
 }
 
 } // namespace WebCore

Modified: trunk/Source/WebCore/webaudio/AudioContext.idl (109869 => 109870)


--- trunk/Source/WebCore/webaudio/AudioContext.idl	2012-03-06 07:40:46 UTC (rev 109869)
+++ trunk/Source/WebCore/webaudio/AudioContext.idl	2012-03-06 07:59:24 UTC (rev 109870)
@@ -30,9 +30,7 @@
         CustomConstructor,
         ConstructorParameters=0,
         JSCustomMarkFunction,
-#if defined(V8_BINDING) && V8_BINDING
         EventTarget
-#endif        
     ] AudioContext {
         // All rendered audio ultimately connects to destination, which represents the audio hardware.
         readonly attribute AudioDestinationNode destination;

Modified: trunk/Source/WebCore/webaudio/_javascript_AudioNode.idl (109869 => 109870)


--- trunk/Source/WebCore/webaudio/_javascript_AudioNode.idl	2012-03-06 07:40:46 UTC (rev 109869)
+++ trunk/Source/WebCore/webaudio/_javascript_AudioNode.idl	2012-03-06 07:59:24 UTC (rev 109870)
@@ -28,9 +28,7 @@
         Conditional=WEB_AUDIO,
         JSGenerateToJSObject,
         JSCustomMarkFunction,
-#if defined(V8_BINDING) && V8_BINDING
         EventTarget
-#endif
     ] _javascript_AudioNode : AudioNode {
         // Rendering callback
         attribute EventListener onaudioprocess;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to