Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a8b3f78d322baecab6e30c5e454410a25f542740
https://github.com/WebKit/WebKit/commit/a8b3f78d322baecab6e30c5e454410a25f542740
Author: Youenn Fablet <[email protected]>
Date: 2023-11-17 (Fri, 17 Nov 2023)
Changed paths:
A
LayoutTests/http/tests/media/media-source/media-source-video-fit-fill-expected.txt
A LayoutTests/http/tests/media/media-source/media-source-video-fit-fill.html
M LayoutTests/platform/mac-wk2/TestExpectations
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
Log Message:
-----------
MediaPlayerPrivateMediaSourceAVFObjC is not handling aspect ratio
preservation signal from HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=264944
rdar://118508061
Reviewed by Eric Carlson and Jer Noble.
MediaPlayer is calling setShouldMaintainAspectRatio but
MediaPlayerPrivateMediaSourceAVFObjC was not implementing it.
Implement it by setting the gravity to AVLayerVideoGravityResizeAspect when we
should maintain aspectRatio and AVLayerVideoGravityResizeAspect otherwise.
This fixes the bug for UI side compositing.
We should do a follow-up to fix it for non UI side compositing.
*
LayoutTests/http/tests/media/media-source/media-source-video-fit-fill-expected.txt:
Added.
* LayoutTests/http/tests/media/media-source/media-source-video-fit-fill.html:
Added.
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setShouldMaintainAspectRatio):
Canonical link: https://commits.webkit.org/270876@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
