Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 56b0d92bb3fe7fbbdd946601c98e2e5b5b68fb75
https://github.com/WebKit/WebKit/commit/56b0d92bb3fe7fbbdd946601c98e2e5b5b68fb75
Author: Gavin Phillips <gavi...@apple.com>
Date: 2023-11-17 (Fri, 17 Nov 2023)
Changed paths:
A
LayoutTests/ipc/send-invalid-sync-stream-message-empty-reply-check-exception-expected.txt
A
LayoutTests/ipc/send-invalid-sync-stream-message-empty-reply-check-exception.html
M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
M Source/WebKit/Platform/IPC/HandleMessage.h
M Source/WebKit/Platform/IPC/StreamServerConnection.cpp
M Source/WebKit/Platform/IPC/StreamServerConnection.h
M Source/WebKit/Shared/IPCStreamTester.cpp
M Source/WebKit/Shared/IPCStreamTester.h
M Source/WebKit/Shared/IPCStreamTester.messages.in
M Source/WebKit/Shared/IPCTester.cpp
M Source/WebKit/Shared/IPCTester.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp
Log Message:
-----------
Add the ability for the IPCTestingAPI to report when a sync stream message
fails to be deserialized correctly
https://bugs.webkit.org/show_bug.cgi?id=264810
rdar://118391408
Reviewed by Alex Christensen.
Add the ability for the IPCTestingAPI to report when a sync stream connection
message fails to be received correctly. The existing behaviour is that no reply
is returned for failed messages. This change records the decoder validity
on failure into a MessageSyncReply so that the IPCTestingAPI can raise
an exception.
*
LayoutTests/ipc/ignoreinvalidmessagesfortesting-stream-connection-expected.txt:
Added.
* LayoutTests/ipc/ignoreinvalidmessagesfortesting-stream-connection.html: Added.
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::createRenderingBackend):
(WebKit::GPUConnectionToWebProcess::createGraphicsContextGL):
(WebKit::GPUConnectionToWebProcess::createRemoteGPU):
* Source/WebKit/Platform/IPC/HandleMessage.h:
(IPC::handleMessageSynchronous):
* Source/WebKit/Platform/IPC/StreamServerConnection.cpp:
(IPC::StreamServerConnection::tryCreate):
(IPC::StreamServerConnection::dispatchStreamMessage):
(IPC::StreamServerConnection::dispatchOutOfStreamMessage):
(IPC::StreamServerConnection::sendDeserializationErrorSyncReply):
* Source/WebKit/Platform/IPC/StreamServerConnection.h:
* Source/WebKit/Shared/IPCStreamTester.cpp:
(WebKit::IPCStreamTester::IPCStreamTester):
(WebKit::IPCStreamTester::syncMessageEmptyReply):
* Source/WebKit/Shared/IPCStreamTester.h:
* Source/WebKit/Shared/IPCStreamTester.messages.in:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp:
(TestWebKitAPI::TEST_F):
Canonical link: https://commits.webkit.org/270892@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
