Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 30866e771708aeeea76f588aa0d46888614c5d9e
https://github.com/WebKit/WebKit/commit/30866e771708aeeea76f588aa0d46888614c5d9e
Author: Mike Wyrzykowski <[email protected]>
Date: 2023-11-22 (Wed, 22 Nov 2023)
Changed paths:
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
M Source/WebGPU/WebGPU/BindGroupLayout.mm
M Source/WebGPU/WebGPU/RenderPipeline.mm
M Source/WebGPU/WebGPU/WebGPU.h
Log Message:
-----------
[WebGPU] Auto-generated bind group layout creation fails when indices are
listed out of order
https://bugs.webkit.org/show_bug.cgi?id=265259
radar://118724953
Reviewed by Dan Glastonbury.
The indices in the auto-generated AB were decoupled from WebGPU's
binding indices however there was an assumption they were linearly
increasing in the shader source which does not necessarily hold.
Remove this false assumption by introducing a seperate variable for
the index which corresponds to the AB index in the generated MSL.
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp:
(WebCore::WebGPU::DeviceImpl::createBindGroupLayout):
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::addPipelineLayouts):
* Source/WebGPU/WebGPU/WebGPU.h:
Canonical link: https://commits.webkit.org/271068@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
