Title: [109928] trunk/LayoutTests
- Revision
- 109928
- Author
- [email protected]
- Date
- 2012-03-06 09:46:29 -0800 (Tue, 06 Mar 2012)
Log Message
[GTK] fullscreen/full-screen-iframe-legacy.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=74279
Reviewed by Eric Carlson.
* fullscreen/full-screen-iframe-legacy.html: Wait for canplaythrough
event on the video and increase the timeout to 100ms to reduce
flakiness. Also set the iframe video url from the main frame
before installing the canplaythrough event listener.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (109927 => 109928)
--- trunk/LayoutTests/ChangeLog 2012-03-06 17:17:13 UTC (rev 109927)
+++ trunk/LayoutTests/ChangeLog 2012-03-06 17:46:29 UTC (rev 109928)
@@ -1,3 +1,15 @@
+2012-03-06 Philippe Normand <[email protected]>
+
+ [GTK] fullscreen/full-screen-iframe-legacy.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=74279
+
+ Reviewed by Eric Carlson.
+
+ * fullscreen/full-screen-iframe-legacy.html: Wait for canplaythrough
+ event on the video and increase the timeout to 100ms to reduce
+ flakiness. Also set the iframe video url from the main frame
+ before installing the canplaythrough event listener.
+
2012-03-06 Pavel Feldman <[email protected]>
Web Inspector: add support for inspection of huge (1M elements) arrays.
Modified: trunk/LayoutTests/fullscreen/full-screen-iframe-legacy.html (109927 => 109928)
--- trunk/LayoutTests/fullscreen/full-screen-iframe-legacy.html 2012-03-06 17:17:13 UTC (rev 109927)
+++ trunk/LayoutTests/fullscreen/full-screen-iframe-legacy.html 2012-03-06 17:46:29 UTC (rev 109928)
@@ -2,25 +2,36 @@
Handle entering full screen security restrictions</p>
<p>To test manually, click the video "full screen" button - the page should enter full screen mode.</p>
<script src=""
+<script src=""
<script>
-function runTest() {
+
+function canplaythrough() {
var frame = document.getElementById('frame');
- waitForEvent(frame.contentDocument, 'webkitfullscreenchange', function() {
- test("document.getElementById('frame').contentDocument.width==document.width")
- endTest();
- });
-
runWithKeyDown(function() {
setTimeout(function() {
consoleWrite("FAIL - did not enter full screen!");
endTest();
- }, 50);
+ }, 100);
var video = frame.contentDocument.getElementsByTagName('video')[0];
video.webkitEnterFullScreen();
});
}
+
+function runTest() {
+ var frame = document.getElementById('frame');
+
+ waitForEvent(frame.contentDocument, 'webkitfullscreenchange', function() {
+ test("document.getElementById('frame').contentDocument.width==document.width")
+ endTest();
+ });
+
+ var video = frame.contentDocument.getElementsByTagName('video')[0];
+ var mediaFile = findMediaFile("video", "../../media/content/test");
+ video.src = ""
+ video.addEventListener('canplaythrough', canplaythrough);
+}
</script>
<iframe id="frame" src="" _onload_="runTest()" width="336" height="256">
</iframe>
Modified: trunk/LayoutTests/fullscreen/resources/legacy.html (109927 => 109928)
--- trunk/LayoutTests/fullscreen/resources/legacy.html 2012-03-06 17:17:13 UTC (rev 109927)
+++ trunk/LayoutTests/fullscreen/resources/legacy.html 2012-03-06 17:46:29 UTC (rev 109928)
@@ -1,7 +1 @@
<video controls width="320" height="240"></video>
-<script src=""
-<script>
- video = mediaElement = document.getElementsByTagName('video')[0];
- var mediaFile = findMediaFile("video", "../../media/content/test");
- video.src = ""
-</script>
Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (109927 => 109928)
--- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-03-06 17:17:13 UTC (rev 109927)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-03-06 17:46:29 UTC (rev 109928)
@@ -74,8 +74,6 @@
BUGWK72694 : fast/canvas/canvas-lineWidth.html = PASS TIMEOUT TEXT
BUGWK73772 : fast/table/multiple-captions-display.xhtml = PASS TEXT
-BUGWK74279 : fullscreen/full-screen-iframe-legacy.html = PASS TEXT
-
BUGWK74288 : fast/events/overflow-events.html = PASS TEXT
BUGWK74297 DEBUG : http/tests/security/cross-origin-xsl-redirect-BLOCKED.html = PASS TEXT
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
