Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0f4bbb2894527c358f16c802fb5ceed21d3c152c
https://github.com/WebKit/WebKit/commit/0f4bbb2894527c358f16c802fb5ceed21d3c152c
Author: Ahmad Saleem <[email protected]>
Date: 2023-11-30 (Thu, 30 Nov 2023)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-a-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-a.html
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-q-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-q.html
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-ref.html
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-s-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-s.html
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-x-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-x.xhtml
M Source/WebCore/rendering/TextDecorationPainter.cpp
Log Message:
-----------
Remove `font` text-decoration color override quirk
https://bugs.webkit.org/show_bug.cgi?id=248662
rdar://problem/102920597
Reviewed by Antti Koivisto.
This patch is to align WebKit with Gecko / Firefox (except one case), Blink /
Chromium and
Web Specification [1] (relevant issue [2]):
[1] https://html.spec.whatwg.org/#phrasing-content-3
[2] https://github.com/whatwg/html/pull/8568
As per above issue, this patch remove quirk around 'font' element overriding
color of
any text decoration.
Additionally, it also import updated tests from WPT:
Upstream Hash:
https://github.com/web-platform-tests/wpt/commit/9f9188a5dc5fa92c462d3d67a612337e7c839599
* Source/WebCore/rendering/TextDecorationPainter.cpp:
(collectStylesForRenderer):
* LayoutTests/TestExpectations: Add all imported tests as [ImageOnlyFailure]
due to slight pixel shifts
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-a.html:
Rebaselined
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-a-expected.html:
Ditto
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-q.html:
Ditto
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-q-expected.html:
Ditto
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-s.html:
Ditto
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-s-expected.html:
Ditto
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-ref.html:
Ditto
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-x.xhtml:
Ditto
*
LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-x-expected.html:
Ditto
Canonical link: https://commits.webkit.org/271338@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
