Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b738ab355f6e5ca1450ef7c5cbfdff9430857a42
https://github.com/WebKit/WebKit/commit/b738ab355f6e5ca1450ef7c5cbfdff9430857a42
Author: Ahmad Saleem <[email protected]>
Date: 2023-12-01 (Fri, 01 Dec 2023)
Changed paths:
A LayoutTests/fast/box-shadow/shadow-box-resize-expected.txt
A LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode-expected.txt
A LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode.html
A LayoutTests/fast/box-shadow/shadow-box-resize.html
M Source/WebCore/rendering/RenderBox.cpp
Log Message:
-----------
Fix shadow repaint issue in vertical-rl mode
https://bugs.webkit.org/show_bug.cgi?id=258740
rdar://problem/111915460
Reviewed by Alan Baradlay.
Merge: https://src.chromium.org/viewvc/blink?revision=177246&view=revision
The original code erroneously flipped the shadow edges when the box is
in vertical-rl writing mode, causing incorrect visual overflow and
repaint rects.
Our actual painting code for shadow is correct. The bug is just about
incorrect invalidation rects.
As per Web Specification [1], the writing-mode should not affect 'box-shadow'
and 'text-shadow' offsets due to purely being physical.
[1] https://drafts.csswg.org/css-writing-modes-3/#physical-only
* Source/WebCore/rendering/RenderBox.cpp:
(RenderBox::applyVisualEffectOverflow):
* LayoutTests/fast/box-shadow/shadow-box-resize.html: Add Test Case
* LayoutTests/fast/box-shadow/shadow-box-resize-expected.txt: Add Test Case
Expectation
* LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode.html: Add Test Case
* LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode-expected.txt: Add
Test Case Expectation
Canonical link: https://commits.webkit.org/271416@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
