Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d3069e015212b6fdd1a49e8f1684cf37243e3eaa
https://github.com/WebKit/WebKit/commit/d3069e015212b6fdd1a49e8f1684cf37243e3eaa
Author: Jeff Miller <[email protected]>
Date: 2023-12-06 (Wed, 06 Dec 2023)
Changed paths:
M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h
M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm
M Source/WebKit/Shared/WebHitTestResultData.cpp
M Source/WebKit/Shared/WebHitTestResultData.h
M Source/WebKit/Shared/WebHitTestResultData.serialization.in
M Source/WebKit/UIProcess/API/APIHitTestResult.h
M Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm
Log Message:
-----------
_WKHitTestResult should expose a mediaIsInFullscreen property
https://bugs.webkit.org/show_bug.cgi?id=265946
rdar://118240128
Reviewed by Wenson Hsieh.
Add a mediaFullscreen property to _WKHitTestResult and plumbing to
API::HitTestResult and
WebKit::WebHitTestResultData to support it.
* Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h:
* Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm:
(-[_WKHitTestResult isMediaFullscreen]):
* Source/WebKit/Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::WebHitTestResultData):
* Source/WebKit/Shared/WebHitTestResultData.h:
* Source/WebKit/Shared/WebHitTestResultData.serialization.in:
* Source/WebKit/UIProcess/API/APIHitTestResult.h:
(API::HitTestResult::mediaIsInFullscreen const):
* Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm:
(TestWebKitAPI::TEST):
Added HitTestResultNonFullscreenMedia test to verify the mediaFullscreen
property is set correctly
on _WKHitTestResult in non-fullscreen. Our API testing infrastructure
(specifically -[TestWKWebView
_mouseDownAtPoint]) doesn't support simulating a mouse down in a fullscreen
video (which isn't in a
window), so I was unable to write a test to for this case, although I verified
that this works
manually.
Canonical link: https://commits.webkit.org/271646@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
