Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ad15255ae7caa863e7d7ad5c975ce266ebece5de
https://github.com/WebKit/WebKit/commit/ad15255ae7caa863e7d7ad5c975ce266ebece5de
Author: Philippe Normand <[email protected]>
Date: 2023-12-14 (Thu, 14 Dec 2023)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M
Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp
M
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp
M
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h
Log Message:
-----------
REGRESSION(271921@main): [GStreamer] ASSERTION FAILED:
!HashTranslator::equal(KeyTraits::emptyValue(), key)
https://bugs.webkit.org/show_bug.cgi?id=266333
Reviewed by Xabier Rodriguez-Calvar.
HashMap doesn't like to store key that evaluate to false, so a TrackID with
value 0 would trigger an
ASSERT. So switch back to unordered_map for tracks storage, and avoid
std::views for access, which
is not available in clang-14.
* LayoutTests/platform/glib/TestExpectations:
*
Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp:
(WebCore::MediaSourcePrivateGStreamer::startPlaybackIfHasAllTracks):
*
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource):
(WebCore::SourceBufferPrivateGStreamer::flush):
(WebCore::SourceBufferPrivateGStreamer::enqueueSample):
(WebCore::SourceBufferPrivateGStreamer::isReadyForMoreSamples):
(WebCore::SourceBufferPrivateGStreamer::notifyClientWhenReadyForMoreSamples):
(WebCore::SourceBufferPrivateGStreamer::allSamplesInTrackEnqueued):
(WebCore::SourceBufferPrivateGStreamer::precheckInitializationSegment):
* Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
Canonical link: https://commits.webkit.org/272028@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
