Title: [110064] trunk
- Revision
- 110064
- Author
- ph...@webkit.org
- Date
- 2012-03-07 09:27:15 -0800 (Wed, 07 Mar 2012)
Log Message
[GTK] media/audio-garbage-collect.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72698
Reviewed by Xan Lopez.
Source/WebCore:
Call ::hasPendingActivity() instead of ::paused() when checking if
the audio element is still active. This is similar to what the
image element (another ActiveDOMObject implementation) does just
above. This contributes to fixing the audio-garbage-collect.html
test.
* bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):
LayoutTests:
* platform/gtk/test_expectations.txt: test is no longer flaky.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (110063 => 110064)
--- trunk/LayoutTests/ChangeLog 2012-03-07 17:23:46 UTC (rev 110063)
+++ trunk/LayoutTests/ChangeLog 2012-03-07 17:27:15 UTC (rev 110064)
@@ -1,3 +1,12 @@
+2012-03-07 Philippe Normand <pnorm...@igalia.com>
+
+ [GTK] media/audio-garbage-collect.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=72698
+
+ Reviewed by Xan Lopez.
+
+ * platform/gtk/test_expectations.txt: test is no longer flaky.
+
2012-03-07 Stephen White <senorbla...@chromium.org>
[chromium] Marking file-writer-events.html as flaky-crashing on Win.
Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (110063 => 110064)
--- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-03-07 17:23:46 UTC (rev 110063)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-03-07 17:27:15 UTC (rev 110064)
@@ -68,7 +68,6 @@
BUGWK80129 : fast/frames/flattening/frameset-flattening-advanced.html = PASS TEXT
BUGWK80129 : fast/frames/flattening/frameset-flattening-subframesets.html = PASS TEXT
-BUGWK72698 : media/audio-garbage-collect.html = PASS TEXT
BUGWK79760 : media/video-poster-blocked-by-willsendrequest.html = PASS TEXT
BUGWK72694 : fast/canvas/canvas-lineWidth.html = PASS TIMEOUT TEXT
Modified: trunk/Source/WebCore/ChangeLog (110063 => 110064)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 17:23:46 UTC (rev 110063)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 17:27:15 UTC (rev 110064)
@@ -1,3 +1,19 @@
+2012-03-07 Philippe Normand <pnorm...@igalia.com>
+
+ [GTK] media/audio-garbage-collect.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=72698
+
+ Reviewed by Xan Lopez.
+
+ Call ::hasPendingActivity() instead of ::paused() when checking if
+ the audio element is still active. This is similar to what the
+ image element (another ActiveDOMObject implementation) does just
+ above. This contributes to fixing the audio-garbage-collect.html
+ test.
+
+ * bindings/js/JSNodeCustom.cpp:
+ (WebCore::isReachableFromDOM):
+
2012-03-07 Adele Peterson <ad...@apple.com>
REGRESSION(r96566): Cursor is I-beam upon dragging an attachment in mail
Modified: trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp (110063 => 110064)
--- trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2012-03-07 17:23:46 UTC (rev 110063)
+++ trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2012-03-07 17:27:15 UTC (rev 110064)
@@ -116,7 +116,7 @@
}
#if ENABLE(VIDEO)
else if (node->hasTagName(audioTag)) {
- if (!static_cast<HTMLAudioElement*>(node)->paused())
+ if (!static_cast<HTMLAudioElement*>(node)->hasPendingActivity())
return true;
}
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
