Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 20d6a4967eff10b34ccdda0fd124f549b363afee
https://github.com/WebKit/WebKit/commit/20d6a4967eff10b34ccdda0fd124f549b363afee
Author: Anne van Kesteren <[email protected]>
Date: 2023-12-18 (Mon, 18 Dec 2023)
Changed paths:
M Source/WebCore/platform/Theme.h
M Source/WebCore/platform/mac/ThemeMac.h
M Source/WebCore/platform/mac/ThemeMac.mm
M Source/WebCore/rendering/RenderThemeMac.mm
Log Message:
-----------
Remove cruft from ThemeMac
https://bugs.webkit.org/show_bug.cgi?id=266539
Reviewed by Aditya Keerthi.
At this point in its life ThemeMac is mainly responsible for
determining the sizing of a couple of form controls as the GPU process
has taken over most of the theming aspects.
And to determine the sizing of these form controls no cells are needed
so all that code can be removed.
And then we also remove some code that eventually does not do anything,
such as StyleAppearance::ColorWell which do to not having the correct
bezel style (which is itself a concept that can be removed) never ends
up being impacted by inflateControlPaintRect().
* Source/WebCore/platform/Theme.h:
(WebCore::Theme::inflateControlPaintRect const):
* Source/WebCore/platform/mac/ThemeMac.h:
* Source/WebCore/platform/mac/ThemeMac.mm:
(WebCore::radioSize):
(WebCore::ThemeMac::inflateControlPaintRect const):
(WebCore::setControlSize): Deleted.
(WebCore::updateStates): Deleted.
(WebCore::configureToggleButton): Deleted.
(WebCore::createToggleButtonCell): Deleted.
(WebCore::sharedRadioCell): Deleted.
(WebCore::sharedCheckboxCell): Deleted.
(WebCore::buttonCell): Deleted.
(WebCore::setUpButtonCell): Deleted.
(WebCore::button): Deleted.
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
Canonical link: https://commits.webkit.org/272218@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
